Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace figlet with console.log() and remove figlet dependency #264

Merged
merged 2 commits into from
May 6, 2024
Merged

Replace figlet with console.log() and remove figlet dependency #264

merged 2 commits into from
May 6, 2024

Conversation

Sadaf-A
Copy link
Contributor

@Sadaf-A Sadaf-A commented Apr 22, 2024

Resolves: #262

This PR Removes the figlet dependency and uses console.log() instead to print the ASCII art

with figlet:
before(1)
with console.log():
after

shalithasuranga
shalithasuranga approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@shalithasuranga shalithasuranga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your work @Sadaf-A 🎉

@shalithasuranga shalithasuranga merged commit d0ad1eb into neutralinojs:main May 6, 2024
2 checks passed
@shalithasuranga shalithasuranga mentioned this pull request May 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shalithasuranga shalithasuranga shalithasuranga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove figlet by printing an ASCII art directly with console.log
2 participants
@Sadaf-A @shalithasuranga