Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/resource busy rmdir #267

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

viralgupta
Copy link
Contributor

fixed Error: EBUSY: resource busy or locked, rmdir '../node' error while creating a neu app on Windows.
This would leave a folder without removing the .tmp files from the folder.

Previous error
image

Current Solution
image

@shalithasuranga
Copy link
Member

Hello @viralgupta Thanks so much for sending this pull request :) Could you please let us know how to reproduce this issue?

Thanks 🎉

@viralgupta
Copy link
Contributor Author

viralgupta commented May 6, 2024

Hi @shalithasuranga , this issue would occur if the default branch were something other than "main," in my case, it was the "master" branch for the "viralgupta/node-neutralinojs-template" template. I had renamed the branch after seeing this issue. So, to reproduce the issue, I have changed it back to the "master" branch for now.

so you can just run this to reproduce the bug
neu create testapp -t viralgupta/node-neutralinojs-template

  • I have ran into this issue on windows, I think this problem don't appear in UNIX based Os's.

ps:

  • should we ask the user if he wants to clone the main branch or a different branch of the repo, because there is no way for the user to create the app using the neu create command if the default branch name is other than "main" since "main" branch is hardcoded in constants.
  • we can use this API to list the branches of a github repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants