ENH: automatic discovery and parsing for pluto.ini, idefix.ini, definitions.h and definitions.hpp #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xshaokun feel free to comment this. I still have a couple embedded TODOs to go over and a couple warnings to write, but I think the structure is ready. |
neutrinoceros
force-pushed
the
auto_parse_def_and_ini
branch
from
113d39b
to
ec09879
Compare
xshaokun
reviewed
Jan 7, 2023
xshaokun
reviewed
Jan 7, 2023
…itions.h and definitions.hpp
neutrinoceros
force-pushed
the
auto_parse_def_and_ini
branch
from
e0ddde2
to
4cee3bd
Compare
|
@xshaokun thank you for your feedback. I'll will now merge this so you can rebase your PR whenever suits you ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for #167