Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Add dependencies to neutrino-dev #36

Closed
darkwing opened this issue Feb 21, 2017 · 3 comments
Closed

Add dependencies to neutrino-dev #36

darkwing opened this issue Feb 21, 2017 · 3 comments

Comments

@darkwing
Copy link

The Jest preset is an awesome step forward. A few more dependencies we should add:

  • react-addons-test-utils
  • enzyme

These allow more react-specific testing, like enzyme to create shallow JSX components. I also needed react-addons-test-utils just for tests to run.

@eliperelman
Copy link
Member

So, since these are dependencies of the project itself, and need to be required from the test, they will need to also be dependencies of the project. Just like React and ReactDOM aren't included in the neutrino-preset-react, these 2 dependencies need to also be required by the project.

Since Jest isn't technically React specific, I think this is going to boil down to better documentation. We should probably add a section to the Jest preset that if you are testing React components, to also include these as devDependencies.

@eliperelman
Copy link
Member

Addressed in #37.

@eliperelman
Copy link
Member

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants