This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Update to ESLint 5 #1025
Merged
Update to ESLint 5 #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updates all dependencies to the latest available to pick up any ESLint 5 compatibility fixes (in the case of `babel-eslint` and `eslint-plugin-vue` this meant beta versions, so for those the tilde range has been changed to exact, pending the final versions). * Raises `ecmaVersion` to `2018`. * Removes all custom `ecmaFeatures` options since: - `impliedStrict` is redundant when using `sourceType: 'module'` - none of the others are recognised by latest ESLint/`babel-eslint` Migration guide: https://eslint.org/docs/user-guide/migrating-to-5.0.0 Docs to help with reviewing the `parserOptions` changes: https://eslint.org/docs/user-guide/configuring#specifying-parser-options https://github.com/babel/babel-eslint#configuration https://eslint.org/docs/rules/strict#rule-details (for `impliedStrict`) Fixes #383. Closes #963. Closes #1001.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
babel-eslintandeslint-plugin-vuethis meant beta versions, so for those the tilde range has been changed to exact, pending the final versions).ecmaVersionto2018.ecmaFeaturesoptions since:impliedStrictis redundant when usingsourceType: 'module'babel-eslintMigration guide:
https://eslint.org/docs/user-guide/migrating-to-5.0.0
Docs to help with reviewing the
parserOptionschanges:https://eslint.org/docs/user-guide/configuring#specifying-parser-options
https://github.com/babel/babel-eslint#configuration
https://eslint.org/docs/rules/strict#rule-details (for
impliedStrict)Fixes #383.
Closes #963.
Closes #1001.