Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ESLint 5 #1025

Merged
merged 1 commit into from Aug 19, 2018
Merged

Update to ESLint 5 #1025

merged 1 commit into from Aug 19, 2018

Conversation

edmorley
Copy link
Member

@edmorley edmorley commented Aug 15, 2018

  • Updates all dependencies to the latest available to pick up any ESLint 5 compatibility fixes (in the case of babel-eslint and eslint-plugin-vue this meant beta versions, so for those the tilde range has been changed to exact, pending the final versions).
  • Raises ecmaVersion to 2018.
  • Removes all custom ecmaFeatures options since:
    • impliedStrict is redundant when using sourceType: 'module'
    • none of the others are recognised by latest ESLint/babel-eslint

Migration guide:
https://eslint.org/docs/user-guide/migrating-to-5.0.0

Docs to help with reviewing the parserOptions changes:
https://eslint.org/docs/user-guide/configuring#specifying-parser-options
https://github.com/babel/babel-eslint#configuration
https://eslint.org/docs/rules/strict#rule-details (for impliedStrict)

Fixes #383.
Closes #963.
Closes #1001.

@edmorley edmorley self-assigned this Aug 15, 2018
@edmorley edmorley added this to the v9 milestone Aug 15, 2018
@edmorley edmorley requested a review from eliperelman Aug 15, 2018
Copy link
Member

@eliperelman eliperelman left a comment

Very nice.

* Updates all dependencies to the latest available to pick up any
  ESLint 5 compatibility fixes (in the case of `babel-eslint` and
  `eslint-plugin-vue` this meant beta versions, so for those the
  tilde range has been changed to exact, pending the final versions).
* Raises `ecmaVersion` to `2018`.
* Removes all custom `ecmaFeatures` options since:
  - `impliedStrict` is redundant when using `sourceType: 'module'`
  - none of the others are recognised by latest ESLint/`babel-eslint`

Migration guide:
https://eslint.org/docs/user-guide/migrating-to-5.0.0

Docs to help with reviewing the `parserOptions` changes:
https://eslint.org/docs/user-guide/configuring#specifying-parser-options
https://github.com/babel/babel-eslint#configuration
https://eslint.org/docs/rules/strict#rule-details (for `impliedStrict`)

Fixes #383.
Closes #963.
Closes #1001.
@edmorley edmorley merged commit 9ceebe7 into neutrinojs:master Aug 19, 2018
2 checks passed
@edmorley edmorley deleted the eslint-5 branch Aug 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants