Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Add description how to ignore files in an IDE lint #205

Merged
merged 5 commits into from Jun 3, 2017

Conversation

constgen
Copy link
Contributor

Please check if everything is described clearly.

@constgen constgen added this to the v6 milestone May 14, 2017
@constgen constgen self-assigned this May 14, 2017
@codecov
Copy link

codecov bot commented May 14, 2017

Codecov Report

Merging #205 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #205   +/-   ##
=======================================
  Coverage   94.14%   94.14%           
=======================================
  Files          36       36           
  Lines         512      512           
=======================================
  Hits          482      482           
  Misses         30       30

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 904ed37...1ca4eee. Read the comment docs.

@@ -127,6 +127,19 @@ pkg.neutrino.use
module.exports = api.eslintrc();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs here need to also be replicated in docs/, but with relative paths.

@@ -127,6 +127,19 @@ pkg.neutrino.use
module.exports = api.eslintrc();
```

Projects authors may also face the problem when their code editor lints all files in the project and highlights errors in all of them. It ignores Neutrino `include` and `exclude` options. This is because editors use CLI to call ESLint instead of Neutrino infrastructure.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Projects may face a problem when their editor or IDE lints all files and highlights errors that were normally excluded from source, i.e. Neutrino's include and exclude options. This is because the ESLint CLI does not have a way to specify included and excluded files from configuration. If you still wish to use ESLint's CLI for linting, consider setting CLI flags or using an eslintignore to choose which files to include or exclude from linting.

@@ -251,6 +251,19 @@ pkg.neutrino.use
module.exports = api.eslintrc();
```

Projects authors may also face the problem when their code editor lints all files in the project and highlights errors in all of them. It ignores Neutrino `include` and `exclude` options. This is because editors use CLI to call ESLint instead of Neutrino infrastructure.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use same copy as I commented elsewhere.

@eliperelman
Copy link
Member

Just wanted to update here that these documentation files still need to be duplicated into the docs/ directory. Ping me if you need more clarification.

@@ -251,6 +251,19 @@ pkg.neutrino.use
module.exports = api.eslintrc();
```

Projects may face a problem when their editor or IDE lints all files and highlights errors that were normally excluded from source, i.e. Neutrino's `include` and `exclude` options. This is because the ESLint CLI does not have a way to specify included and excluded files from configuration. If you still wish to use ESLint's CLI for linting, consider setting [CLI flags](http://eslint.org/docs/user-guide/command-line-interface#options) or using an [eslintignore](http://eslint.org/docs/user-guide/configuring#ignoring-files-and-directories) to choose which files to include or exclude from linting.

Unfortunately ESlint doesn't provide possibility to configure ignored paths from `.neutrino.js` to exclude them from linting. Projects authors should define this manually in their project root directory in `.eslintignore` file.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace all .neutrino.js with "Neutrino configuration".

@eliperelman eliperelman merged commit 5eefb0f into master Jun 3, 2017
@eliperelman eliperelman deleted the doc/eslint-ignore branch June 13, 2017 16:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants