This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
pass clean options to webpack plugin #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliperelman
suggested changes
Dec 2, 2017
| @@ -53,6 +56,11 @@ module.exports = (neutrino, opts = {}) => { | |||
| }, options.babel) | |||
| }); | |||
|
|
|||
| Object.assign(options.clean, opts.clean || {}); | |||
There was a problem hiding this comment.
I don't think you need these lines since you are already setting defaults on line 34. You should be able to safely delete L59-63.
| @@ -30,7 +30,10 @@ module.exports = (neutrino, opts = {}) => { | |||
| polyfills: { | |||
| async: true | |||
| }, | |||
| babel: {} | |||
| babel: {}, | |||
| clean: { | |||
There was a problem hiding this comment.
It would also be nice to disable cleaning by passing false to options.clean. You should be able to achieve this by changing this to:
clean: opts.clean !== false && {
paths: [neutrino.options.output]
}Allow passing false to disable the clean plugin
eliperelman
suggested changes
Dec 3, 2017
| @@ -143,7 +146,12 @@ module.exports = (neutrino, opts = {}) => { | |||
| .use(optimize.ModuleConcatenationPlugin); | |||
| }) | |||
| .when(neutrino.options.command === 'build', (config) => { | |||
| neutrino.use(clean, { paths: [neutrino.options.output] }); | |||
| if (options.clean) { | |||
There was a problem hiding this comment.
For consistency with the rest of the middleware, could you switch this to .when? Also, I don't think we need to include the output condition here since you have that set above in the options with paths: [neutrino.options.clean]:
config.when(options.clean, () => neutrino.use(clean, options.clean));I'm still a bit confuse with that API but learning... Thanks for the guidance
|
I discovered that the clean middleware was also not passing all options, so I corrected it on the fly. |
eliperelman
approved these changes
Dec 4, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope this is the right way to fix #502 :)