This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

add react & react-dom as peer dependency, fix #94 #95

Closed

gasolin wants to merge 1 commit into neutrinojs:master from gasolin:peerdep

Contributor

gasolin commented Mar 5, 2017

No description provided.


          add react & react-dom as peer dependency, fix neutrinojs#94

54c49d7

Member

eliperelman commented Mar 5, 2017

Unfortunately we can't add these as peerDeps for a couple reasons:

peerDeps can't be disabled. If someone wants to create a neutrino-preset-preact based on the react preset, they won't be able to get rid of the warnings.
Using versions is a maintenance burden on the preset, and we made this mistake with Neo. By specifying a version, we are forced to track with React when their version changes, possibly falling behind.

I think the right thing to do is document it the best we can.

eliperelman closed this

eliperelman mentioned this pull request

add react and react-dom as peerDependencies in preset-react #94

Closed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.