Add all possible types for Plugin.use and Plugin.init

neutrinojs · Dec 3, 2019 · 9fdfdfb · 9fdfdfb
1 parent 7136200
commit 9fdfdfb
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/types/index.d.ts b/types/index.d.ts
@@ -84,8 +84,8 @@ declare namespace Config {
   class Plugins<Parent, PluginType extends Tapable.Plugin = webpack.Plugin> extends TypedChainedMap<Parent, Plugin<Parent, PluginType>> {}
 
   class Plugin<Parent, PluginType extends Tapable.Plugin = webpack.Plugin> extends ChainedMap<Parent> implements Orderable {
-    init(value: (plugin: PluginClass<PluginType>, args: any[]) => PluginType): this;
-    use(plugin: PluginClass<PluginType>, args?: any[]): this;
+    init(value: (plugin: PluginType | PluginClass<PluginType>, args: any[]) => PluginType): this;
+    use(plugin: string | PluginType | PluginClass<PluginType>, args?: any[]): this;
     tap(f: (args: any[]) => any[]): this;
 
     // Orderable

diff --git a/types/test/webpack-chain-tests.ts b/types/test/webpack-chain-tests.ts
@@ -185,10 +185,20 @@ config
     .after('bar')
     .end()
 
+  .plugin('asString')
+    .use('package-name-or-path')
+    .end()
+
+  .plugin('asObject')
+    .use({ apply: (compiler: webpack.Compiler) => {}})
+    .end()
+
   .plugins
     .delete('foo')
     .delete('bar')
     .delete('baz')
+    .delete('asString')
+    .delete('asObject')
     .end()
 
   .node