Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Support devServer.sockHost, devServer.sockPath, and devServer.sockPort #231

Closed
joeldenning opened this issue Jan 9, 2020 · 3 comments · Fixed by #238
Closed

Support devServer.sockHost, devServer.sockPath, and devServer.sockPort #231

joeldenning opened this issue Jan 9, 2020 · 3 comments · Fixed by #238

Comments

@joeldenning
Copy link
Contributor

joeldenning commented Jan 9, 2020

Thanks for your work on this project - I enjoy using it.

I would love to see devServer.sockHost, devServer.sockPort, and devServer.sockPath supported in webpack chain. As far as I can tell, they currently are not supported at all.

@edmorley
Copy link
Member

Hi! Thank you for filing this issue - I agree webpack-chain should support these. Would you be open to creating a PR for it? :-)

@joeldenning
Copy link
Contributor Author

I created #238 to resolve this. In doing so, I realized that it was already possible to set the sockHost, sockPath, and sockPort via config.devServer.set('sockHost', '8080'). However, my PR adds the shorthand methods for them: config.devServer.sockHost('8080')

@edmorley
Copy link
Member

Awesome, thank you :-)

I realized that it was already possible to set the sockHost, sockPath, and sockPort via config.devServer.set('sockHost', '8080')

Yeah the long form is useful to work around lack of support, but adding the shorthand methods longer term is the best approach.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants