This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
feat: rule test supports function #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinymins
force-pushed
the
rule-test-function
branch
from
e968f35
to
c458681
Compare
eliperelman
suggested changes
May 8, 2019
test/Rule.js
Outdated
| @@ -131,6 +131,15 @@ test('toConfig with values', t => { | |||
| }); | |||
| }); | |||
|
|
|||
| test('toConfig with test function', t => { | |||
| const rule = new Rule(); | |||
| const test = s => s.indexOf('.js') >= 0; | |||
There was a problem hiding this comment.
Can you make this:
const test = s => s.includes('.js');
src/Rule.js
Outdated
| @@ -87,7 +87,11 @@ const Rule = Orderable( | |||
| } | |||
|
|
|||
| if (!omit.includes('test') && 'test' in obj) { | |||
| this.test(obj.test instanceof RegExp ? obj.test : new RegExp(obj.test)); | |||
| this.test( | |||
| obj.test instanceof RegExp || obj.test instanceof Function | |||
There was a problem hiding this comment.
Can you change obj.test instanceof Function to typeof obj.test === 'function'?
tinymins
force-pushed
the
rule-test-function
branch
from
c458681
to
5e23771
Compare
tinymins
force-pushed
the
rule-test-function
branch
from
5e23771
to
3f1b951
Compare
|
@eliperelman Thanks for your advice, all changes applied. |
eliperelman
approved these changes
May 17, 2019
|
Published in v6.1.0 :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #171.