Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Add support for module.strictExportPresence and output.futureEmitAssets #207

Merged
merged 4 commits into from Dec 15, 2019
Merged

Add support for module.strictExportPresence and output.futureEmitAssets #207

merged 4 commits into from Dec 15, 2019

Conversation

yordis
Copy link
Contributor

@yordis yordis commented Oct 23, 2019 •
edited

fixes #205 #206

@yordis
Copy link
Contributor Author

yordis commented Oct 23, 2019

@edmorley @eliperelman if you merge this, would you mind releasing a new version?

@yordis
Copy link
Contributor Author

yordis commented Dec 9, 2019

@edmorley I am sorry for bothering you, but could you give me a hand with this?

edmorley
edmorley suggested changes Dec 13, 2019
View reviewed changes
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay here - I'm not actively working on webpack-chain at the moment.

If you could make the one change here, happy to merge/release after :-)

src/Output.js Outdated Show resolved Hide resolved
@yordis yordis requested a review from edmorley December 15, 2019 05:45
@yordis
Copy link
Contributor Author

yordis commented Dec 15, 2019

@edmorley done

@edmorley edmorley changed the title Add missing props Add support for module.strictExportPresence and output.futureEmitAssets Dec 15, 2019
edmorley
edmorley approved these changes Dec 15, 2019
View reviewed changes
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :-)

@edmorley edmorley merged commit 59dfdaf into neutrinojs:master Dec 15, 2019
@yordis yordis deleted the yordis/add-misising-keys branch December 15, 2019 10:16
@edmorley
Copy link
Member

Published in 6.2.0 :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@edmorley edmorley edmorley approved these changes

Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add futureEmitAssets to output
2 participants
@yordis @edmorley