Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

fix: fix type definition for Rule#oneOf #218

Merged
merged 1 commit into from Dec 19, 2019
Merged

fix: fix type definition for Rule#oneOf #218

merged 1 commit into from Dec 19, 2019

Conversation

loveky
Copy link
Contributor

@loveky loveky commented Dec 18, 2019

changes the type of oneOf's return value to Rule as it should be and make sure its parent is the original Rule instance.

@loveky loveky mentioned this pull request Dec 18, 2019
Closed
@opl-
Copy link
Contributor

opl- commented Dec 19, 2019

LGMT

@opl- opl- mentioned this pull request Dec 19, 2019
Closed
@edmorley edmorley added the bug label Dec 19, 2019
edmorley
edmorley approved these changes Dec 19, 2019
View reviewed changes
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :-)

@edmorley edmorley merged commit 7fb3c67 into neutrinojs:master Dec 19, 2019
@edmorley
Copy link
Member

Published in v6.3.0 :-)

@edmorley edmorley added types and removed bug labels Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@edmorley edmorley edmorley approved these changes

@opl- opl- opl- approved these changes

Assignees
No one assigned
Labels
types
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@loveky @opl- @edmorley