Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fix types for TypedChainedMap.getOrCompute missing #221

Merged
merged 2 commits into from Dec 21, 2019
Merged

Fix types for TypedChainedMap.getOrCompute missing #221

merged 2 commits into from Dec 21, 2019

Conversation

opl-
Copy link
Contributor

@opl- opl- commented Dec 19, 2019

No description provided.

@edmorley edmorley added the bug label Dec 21, 2019
edmorley
edmorley suggested changes Dec 21, 2019
View reviewed changes
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thank you for the fix. Could you add a usage of getOrCompute() to types/test/webpack-chain-tests.ts? :-)

@opl-
Copy link
Contributor Author

opl- commented Dec 21, 2019

I guess the PR just grew in scope a little. Added tests for the entirety of TypedChainedMap and TypedChainedSet. Since the package doesn't export either and TS didn't like me importing them directly, I reused the values from config for the tests, under the assumption that they're unlikely to change in the future.

edmorley
edmorley approved these changes Dec 21, 2019
View reviewed changes
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :-)

@edmorley edmorley merged commit df193ec into neutrinojs:master Dec 21, 2019
@edmorley
Copy link
Member

Published in v6.3.0 :-)

@edmorley edmorley added types and removed bug labels Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@edmorley edmorley edmorley approved these changes

Assignees
No one assigned
Labels
types
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@opl- @edmorley