-
Notifications
You must be signed in to change notification settings - Fork 230
Conversation
- add Callable Class - rename `name` to avoid conflict with Function readonly property - allow Config.node(false)
- Other Options - Experiments - Stats - Node - Performance - Externals - Watch and WatchOptions - Target - Devtool - DevServer - Plugins - Optimization
- resolve
- Module
- Output
- ResolveLoader
rename config.name to config.configName
@edmorley I have no idea how to deal with Travis CI, any idea? |
@githoniel Thank you for the PR!
Unfortunately there are no more Travis CI credits, so this repo needs to be migrated to eg GitHub actions: Such a migration is a blocker for merging any other PRs. |
2cf690d
to
8abbf6a
Compare
7e0182e
to
82a8ab5
Compare
82a8ab5
to
a9c3870
Compare
`@types/webpack-dev-server@4.1.0` require `http-proxy-middleware@2.0.1` require for node v12+
@0x1af2aec8f957 |
yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thank you for your work on this, and sorry for the delay in taking a look at it.
The PR is pretty large at the moment (+2,717 −3,358) and contains several different types of changes, which makes it harder to review.
Would it be possible to split as many changes out of the PR as possible that aren't directly related to webpack 5? For example these should be separate PRs:
- Dropping support for Node 10
- Adding a new ChainedValueMap concept (not sure I follow why this is needed? The PR description in a new PR would help me understand this)
- Refactoring webpack-chain base classes (such as the new
src/createClass/*
additions) - The sorting some of the existing properties/keys or sections README sections alphabetically
Many thanks :-)
@githoniel |
I will split this later |
): this; | ||
devtoolNamespace(value: WebpackOutput['devtoolNamespace']): this; | ||
filename(value: WebpackOutput['filename']): this; | ||
assetModuleFilenamet(value: WebpackOutput['assetModuleFilename']): this; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assetModuleFilenamet(value: WebpackOutput['assetModuleFilename']): this; | |
assetModuleFilename(value: WebpackOutput['assetModuleFilename']): this; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I submitted a pull request here before: githoniel#2
I've now done this in #318. I've also bumped the version on Please could new PRs be created for these:
And just to emphasises - I don't have the time to work on this project myself (I'm not using webpack or doing much front-end any more), so people other than me will need to drive this work. Thank you for everyone's help so far! :-) |
any progress here? |
This PR has been published under https://www.npmjs.com/package/@gem-mine/webpack-chain The work involved here is to split the many changes into consumable bits. Makes for better changelogs and better reviews. As far as I know, no one has started the asked split. |
Hi, how long does it take to upgrade? |
Thanks for your work! Is there any ambition to finish this PR? |
Hi, it's already year 2023 and I can't wait to use this new feature in webpack5. So, how is the progress going with that? |
@AdvancedCat An easy way is: |
Closing since this project is no longer maintained: |
this PR will make
webpack-chain
work with webpack5 #266I have checked the documentation for all supported options.
CreateClass(superClass)
to support chained class inheritedModule Contexts
options. since they are document as deprecated and will soon be removed, so only parameters that the demo is provided in the documentation are supportedChainedValueMap
to support object/boolean type fornode/performance
option as Support Config.node false value #252 suggested, API likeconfig.node(false)
.webpack
itself