support webpack 5.x #297

githoniel · 2021-05-10T02:59:25Z

this PR will make webpack-chain work with webpack5 #266

I have checked the documentation for all supported options.

Class: use CreateClass(superClass) to support chained class inherited
Configuration: support almost all options in webpack5 and remove undocumented options.
- partial support Module Contexts options. since they are document as deprecated and will soon be removed, so only parameters that the demo is provided in the documentation are supported
- add new type ChainedValueMap to support object/boolean type for node/performance option as Support Config.node false value #252 suggested, API like config.node(false).
- add tests for new config
Type declaration: use the type definition that comes with webpack itself
CI: change to use Github Actions
Doc: readme has updated

- add Callable Class - rename `name` to avoid conflict with Function readonly property - allow Config.node(false)

- Other Options - Experiments - Stats - Node - Performance - Externals - Watch and WatchOptions - Target - Devtool - DevServer - Plugins - Optimization

- resolve

- Module

- Output

- ResolveLoader

rename config.name to config.configName

githoniel · 2021-05-10T05:46:45Z

@edmorley I have no idea how to deal with Travis CI, any idea?

edmorley · 2021-05-10T08:05:04Z

@githoniel Thank you for the PR!

I have no idea how to deal with Travis CI, any idea?

Unfortunately there are no more Travis CI credits, so this repo needs to be migrated to eg GitHub actions:
#266 (comment)

Such a migration is a blocker for merging any other PRs.

… to webpack5

`@types/webpack-dev-server@4.1.0` require `http-proxy-middleware@2.0.1` require for node v12+

githoniel · 2021-09-08T03:55:33Z

@0x1af2aec8f957
It should be assetModuleFilename not assetModuleFilenamet ?

0x1af2aec8f957 · 2021-09-08T05:32:20Z

@0x1af2aec8f957
It should be assetModuleFilename not assetModuleFilenamet ?

yes

edmorley

Hi! Thank you for your work on this, and sorry for the delay in taking a look at it.

The PR is pretty large at the moment (+2,717 −3,358) and contains several different types of changes, which makes it harder to review.

Would it be possible to split as many changes out of the PR as possible that aren't directly related to webpack 5? For example these should be separate PRs:

Dropping support for Node 10
Adding a new ChainedValueMap concept (not sure I follow why this is needed? The PR description in a new PR would help me understand this)
Refactoring webpack-chain base classes (such as the new src/createClass/* additions)
The sorting some of the existing properties/keys or sections README sections alphabetically

Many thanks :-)

0x1af2aec8f957 · 2021-09-08T11:02:43Z

@githoniel
A new type inference problem was found：webpack-contrib/terser-webpack-plugin#443 (comment)

githoniel · 2021-09-09T09:57:55Z

Hi! Thank you for your work on this, and sorry for the delay in taking a look at it.

The PR is pretty large at the moment (+2,717 −3,358) and contains several different types of changes, which makes it harder to review.

Would it be possible to split as many changes out of the PR as possible that aren't directly related to webpack 5? For example these should be separate PRs:

Dropping support for Node 10

Adding a new ChainedValueMap concept (not sure I follow why this is needed? The PR description in a new PR would help me understand this)

Refactoring webpack-chain base classes (such as the new src/createClass/* additions)

The sorting some of the existing properties/keys or sections README sections alphabetically

Many thanks :-)

I will split this later

imaegoo · 2021-10-09T02:16:58Z

types/index.d.ts

+    ): this;
+    devtoolNamespace(value: WebpackOutput['devtoolNamespace']): this;
+    filename(value: WebpackOutput['filename']): this;
+    assetModuleFilenamet(value: WebpackOutput['assetModuleFilename']): this;


@githoniel

Suggested change

assetModuleFilenamet(value: WebpackOutput['assetModuleFilename']): this;

assetModuleFilename(value: WebpackOutput['assetModuleFilename']): this;

I submitted a pull request here before: githoniel#2

edmorley · 2021-10-13T09:51:56Z

Would it be possible to split as many changes out of the PR as possible that aren't directly related to webpack 5? For example these should be separate PRs:
* Dropping support for Node 10

I've now done this in #318. I've also bumped the version on main to v7, since main now contains breaking changes.

Please could new PRs be created for these:

* Adding a new ChainedValueMap concept (not sure I follow why this is needed? The PR description in a new PR would help me understand this)
* Refactoring webpack-chain base classes (such as the new `src/createClass/*` additions)
* The sorting some of the existing properties/keys or sections README sections alphabetically

And just to emphasises - I don't have the time to work on this project myself (I'm not using webpack or doing much front-end any more), so people other than me will need to drive this work. Thank you for everyone's help so far! :-)

denghongcai · 2022-01-11T02:46:20Z

any progress here?

Nic128 · 2022-01-11T14:10:58Z

This PR has been published under https://www.npmjs.com/package/@gem-mine/webpack-chain before the requests here for change. I have been using that fork publish for my own private webpack 5 neutrino fork. I have not had much issues, at least for my usage.

The work involved here is to split the many changes into consumable bits. Makes for better changelogs and better reviews. As far as I know, no one has started the asked split.

CoreyBin · 2022-02-01T07:21:09Z

Hi, how long does it take to upgrade?

suanmei · 2022-03-15T09:03:05Z

Thanks for your work firstly.
There is a question about the Type Definition when I use config.devtool('eval-cheap-module-source-map').

Webpack5's sourceMap named-style is ^(inline-|hidden-|eval-)?(nosources-)?(cheap-(module-)?)?source-map$

lindelleric · 2022-09-28T11:05:14Z

Thanks for your work! Is there any ambition to finish this PR?

AdvancedCat · 2023-04-18T02:28:19Z

Hi, it's already year 2023 and I can't wait to use this new feature in webpack5. So, how is the progress going with that?

imaegoo · 2023-04-18T02:38:16Z

Hi, it's already year 2023 and I can't wait to use this new feature in webpack5. So, how is the progress going with that?

@AdvancedCat An easy way is: yarn remove webpack-chain && yarn add -D @gem-mine/webpack-chain

edmorley · 2024-02-03T19:31:47Z

Closing since this project is no longer maintained:
#358

renovate-bot and others added 12 commits March 26, 2021 12:48

Update dependency webpack to v5

478efce

test: fix test for new webpack validate api

5daf877

feat: add ChainedValueMap to support false/object value type

23db2b7

- add Callable Class - rename `name` to avoid conflict with Function readonly property - allow Config.node(false)

feat: support webpack5

ec06779

- Other Options - Experiments - Stats - Node - Performance - Externals - Watch and WatchOptions - Target - Devtool - DevServer - Plugins - Optimization

feat: support webpack5

a3689b8

- resolve

fix: devserver allowedHosts duplicate

c0a3bfa

feat: support webpack5

e4c5ef5

- Module

feat: support webpack5

a32e032

- Output

feat: support webpack5

10bc836

- ResolveLoader

fix: syntax mistakes

230094f

feat: better name confict

11c114b

rename config.name to config.configName

chore: bump version to 7.0.0

8386ac2

chore: style:fix

019fd7d

githoniel marked this pull request as draft May 10, 2021 13:13

githoniel added 2 commits May 11, 2021 11:03

refactor: use createClass to support multi-extend, avoid name conflict

25bd739

chore: remove empty file

def9bd6

githoniel force-pushed the renovate/webpack-5.x branch 2 times, most recently from 2cf690d to 8abbf6a Compare May 11, 2021 15:13

githoniel added 6 commits May 12, 2021 10:46

fix: allow config.performance(false)

d6ff817

fix: remove webpack5 removed options

e7e9c58

feat: convert optimization.splitChunks to ChainedValueMap

af84878

test: add test

2333b51

chore: style fix

4859d3b

feat: update d.ts

89adb1a

githoniel force-pushed the renovate/webpack-5.x branch 2 times, most recently from 7e0182e to 82a8ab5 Compare May 12, 2021 02:52

chore: use github action

a9c3870

githoniel force-pushed the renovate/webpack-5.x branch from 82a8ab5 to a9c3870 Compare May 12, 2021 02:56

githoniel added 3 commits September 8, 2021 11:23

fix: remove @types/tapable and @types/enhanced-resolve

7f8f01f

fix: since @types/webpack-dev-server still use webpack4, resolvetions…

6c93a4f

… to webpack5

chore: remove test on node 10

0e8cd67

`@types/webpack-dev-server@4.1.0` require `http-proxy-middleware@2.0.1` require for node v12+

0x1af2aec8f957 mentioned this pull request Sep 8, 2021

Fix Output.assetmodulefilename type definition githoniel/webpack-chain#2

Open

edmorley suggested changes Sep 8, 2021

View reviewed changes

robothot mentioned this pull request Oct 8, 2021

Webpack 5 support #266

Closed

imaegoo reviewed Oct 9, 2021

View reviewed changes

edmorley added this to the webpack-chain 7 milestone Oct 13, 2021

edmorley added the breaking change label Oct 13, 2021

edmorley mentioned this pull request Oct 13, 2021

Update dependency @types/tapable to v2 #289

Closed

1 task

edmorley mentioned this pull request Oct 13, 2021

Update dependency webpack to v5 #280

Closed

1 task

edmorley added the help wanted label Oct 13, 2021

lbineau mentioned this pull request Feb 28, 2022

Asset modules assetModuleFilename vuejs/vue-cli#7009

Open

AdvancedCat mentioned this pull request Apr 30, 2023

用webpack5编译时可以使用node的原生模块crypto和zlib NervJS/taro#12784

Open

Nelfimov mentioned this pull request Sep 15, 2023

webpack upgrade atls/raijin#255

Closed

edmorley closed this Feb 3, 2024

edmorley mentioned this pull request Feb 3, 2024

This project is no longer maintained #358

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

support webpack 5.x #297

support webpack 5.x #297

githoniel commented May 10, 2021 •

edited

Loading

githoniel commented May 10, 2021

edmorley commented May 10, 2021

githoniel commented Sep 8, 2021

0x1af2aec8f957 commented Sep 8, 2021

edmorley left a comment •

edited

Loading

0x1af2aec8f957 commented Sep 8, 2021

githoniel commented Sep 9, 2021

imaegoo Oct 9, 2021

0x1af2aec8f957 Oct 9, 2021

edmorley commented Oct 13, 2021 •

edited

Loading

denghongcai commented Jan 11, 2022

Nic128 commented Jan 11, 2022

CoreyBin commented Feb 1, 2022

suanmei commented Mar 15, 2022

lindelleric commented Sep 28, 2022

AdvancedCat commented Apr 18, 2023

imaegoo commented Apr 18, 2023

edmorley commented Feb 3, 2024

	assetModuleFilenamet(value: WebpackOutput['assetModuleFilename']): this;
	assetModuleFilename(value: WebpackOutput['assetModuleFilename']): this;

support webpack 5.x #297

support webpack 5.x #297

Conversation

githoniel commented May 10, 2021 • edited Loading

githoniel commented May 10, 2021

edmorley commented May 10, 2021

githoniel commented Sep 8, 2021

0x1af2aec8f957 commented Sep 8, 2021

edmorley left a comment • edited Loading

Choose a reason for hiding this comment

0x1af2aec8f957 commented Sep 8, 2021

githoniel commented Sep 9, 2021

imaegoo Oct 9, 2021

Choose a reason for hiding this comment

0x1af2aec8f957 Oct 9, 2021

Choose a reason for hiding this comment

edmorley commented Oct 13, 2021 • edited Loading

denghongcai commented Jan 11, 2022

Nic128 commented Jan 11, 2022

CoreyBin commented Feb 1, 2022

suanmei commented Mar 15, 2022

lindelleric commented Sep 28, 2022

AdvancedCat commented Apr 18, 2023

imaegoo commented Apr 18, 2023

edmorley commented Feb 3, 2024

githoniel commented May 10, 2021 •

edited

Loading

edmorley left a comment •

edited

Loading

edmorley commented Oct 13, 2021 •

edited

Loading