Rename module-xrdp-pipewire into module-xrdp #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pipewire suffix is redundant, so we drop it. In practice, what this commit does: 1) Rename the source file from module-xrdp-pipewire.c to module-xrdp.c, thus we're in line with the naming scheme for modules in the pipewire source tree: ``` $ ls <pipewire-git-tree>/src/modules flatpak-utils.h meson.build module-access.c module-adapter module-adapter.c [...] ``` 2) Rename the library that is built, from libpipewire-module-xrdp-pipewire.so to libpipewire-module-xrdp.so, once again to be in line with the naming scheme used by pipewire upstream: ``` $ ls -1 /usr/lib/x86_64-linux-gnu/pipewire-0.3/ libpipewire-module-access.so libpipewire-module-adapter.so libpipewire-module-avb.so libpipewire-module-client-device.so libpipewire-module-client-node.so ``` This change is cosmetic, it doesn't fix any known issue.
|
Good idea. |
This was referenced Mar 26, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pipewire suffix is redundant, so we drop it.
In practice, what this commit does:
thus we're in line with the naming scheme for modules in the pipewire
source tree:
libpipewire-module-xrdp-pipewire.so to libpipewire-module-xrdp.so,
once again to be in line with the naming scheme used by pipewire
upstream:
This change is cosmetic, it doesn't fix any known issue.