Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Improvements #61

Merged
merged 2 commits into from
Oct 13, 2021
Merged

CI Improvements #61

merged 2 commits into from
Oct 13, 2021

Conversation

matt335672
Copy link
Member

Added the following to the CI:-

  • An extra compiler (CLANG)
  • Compiler flags -Wall -Wextra -Werror

The CI has been restructured into three jobs. The first gets the PA sources, and the other two then build the module against these sources. A dependency prevents the compilers running until the sources are available.

Example output from the CI is here:-

https://github.com/matt335672/pulseaudio-module-xrdp/actions/runs/1330330090

The second commit fixes the compiler warnings/errors generated for unused variables:-

 CC       module_xrdp_sink_la-module-xrdp-sink.lo
module-xrdp-sink.c: In function ‘thread_func’:
module-xrdp-sink.c:376:15: error: unused variable ‘now’ [-Werror=unused-variable]
  376 |     pa_usec_t now;
      |               ^~~
module-xrdp-sink.c:375:9: error: unused variable ‘ret’ [-Werror=unused-variable]
  375 |     int ret;
      |         ^~~
cc1: all warnings being treated as errors
make[2]: *** [Makefile:481: module_xrdp_sink_la-module-xrdp-sink.lo] Error 1

@matt335672 matt335672 merged commit b4d03c5 into neutrinolabs:devel Oct 13, 2021
@matt335672 matt335672 deleted the extra_actions branch November 9, 2021 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants