Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable touchpad inertial scrolling(fix touchpad scrolls too fast) #234

Merged
merged 5 commits into from
Sep 16, 2022

Conversation

seflerZ
Copy link
Contributor

@seflerZ seflerZ commented Sep 12, 2022

Close #150 @metalefty
The xrdpMouse module doesn't handle touchpad inertial scrolling properly. At first I was intented to write a touchpad driver, now I found it uncessary. Because the RDP protocol doesn't have a touchpad channel, it should be good to add some touchpad function in the xrdpMouse driver.

Now the scrolling works great both on vertical and horizontal scrollings. Inertial scrolling also supported.
touchpad-scroll_Trim

Note: Some applications such as Firefox which uses WebKitGTK, have their own inertial handling process, so it won't work on every applications.

@metalefty
Copy link
Member

Thanks, CI is failing but that's fine. This PR depends on neutrinolabs/xrdp#2364.

@seflerZ
Copy link
Contributor Author

seflerZ commented Sep 13, 2022

@metalefty I've rebased the codes. Since the driver functions have been added. I deleted those hack codes at the same time.

BTW: Is there any tool or coding style guidance to pass the CI code style check?

@matt335672
Copy link
Member

Hi @seflerZ

coding standard is on the wiki.

Alternatively, there's a script run_astyle.sh in the xrdp/scripts directory that formats all your code for you using the astyle utility.

I can see that this PR won't compile until neutrinolabs/xrdp#2364 is merged.

Hope that's useful.

@seflerZ
Copy link
Contributor Author

seflerZ commented Sep 13, 2022

@matt335672 Got it. I've fixed the code style issues in neutrinolabs/xrdp#2364.

@matt335672
Copy link
Member

@metalefty - I'm unable to re-run the CI checks on this PR for some reason. Can you?

@metalefty
Copy link
Member

Re-ran CI jobs.

@matt335672
Copy link
Member

LGTM. @metalefty?

@metalefty
Copy link
Member

LGTM, too.

@matt335672 matt335672 merged commit 150c0b2 into neutrinolabs:devel Sep 16, 2022
@seflerZ
Copy link
Contributor Author

seflerZ commented Sep 16, 2022

Thanks for code review. @metalefty & @matt335672

@furrnace
Copy link

starting from which release version is this fix included in xrdp?

@neutrinolabs neutrinolabs locked as resolved and limited conversation to collaborators Aug 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vertical scroll speed too fast (xrdpMouse)
4 participants