Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a RandR output before the first client connects #254

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

matt335672
Copy link
Member

Prompted by neutrinolabs/xrdp#2580

This allows clients expecting RandR outputs to work correctly if no client is connected at startup (i.e. if xrdp-sesrun is used)

@Nexarian
Copy link
Contributor

This feels reasonable, and may have good side effects for GFX as well...

@Nexarian
Copy link
Contributor

@jsorg71 What do you think? Will this have any side effects for the Nvidia integration or LRandr?

@jsorg71
Copy link
Contributor

jsorg71 commented Mar 16, 2023

I'll have to check and make sure there is always a default output when LRANDR is used.
I do have a few comments about waitforx I'll make over there.

@jsorg71
Copy link
Contributor

jsorg71 commented Mar 16, 2023

No code in xrdpdev is used when nvidia wrapper is used. We can make sure LRANDR has a default output later.

Copy link
Contributor

@jsorg71 jsorg71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@metalefty metalefty merged commit a07c9c8 into neutrinolabs:devel Mar 17, 2023
@matt335672 matt335672 deleted the start_output_on_startup branch March 17, 2023 10:09
@matt335672
Copy link
Member Author

@jsorg71 - as regards waitforx, I'm hoping to make use of this to validate the X server before starting the session.

The intention is to remove a whole class of "blue screen" problems where the X server doesn't start properly, and xrdp then spends 30 seconds trying to connect to it. At the moment it takes specialist knowledge to distinguish this situation from a similar one where the session fails to start.

Details and screenshots at neutrinolabs/xrdp#2592. This is still in draft, but should be ready for review in the next few days.

@metalefty
Copy link
Member

@matt335672 Should we backport this to v0.9?

@matt335672
Copy link
Member Author

I don't think so. No-one's complained about it, and you can't use xrdp-sesrun very easily in that version to start unattended sessions.

@metalefty
Copy link
Member

Thanks, then inertial scrolling is the only change included in the next xorgxrdp v0.9 release. I'll go forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants