Switch to wyhash from CRC for capture tile diff #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally suggested by @trishume at neutrinolabs#167.
Originally developed @trishume.
matt335672
reviewed
Apr 5, 2024
|
I tested both wyhash and xxhash64 with lazy color convert. See #300 for results. I'm inclined to use wyhash. @jsorg71 @Nexarian @matt335672 Any thoughts about which hash algorithm to use? |
|
I'll agree meta, I feel like we vetted wyhash well. I'm not concerned about the author as this is not used for security. |
|
I think you've done a great job looking at this @metalefty. Because wyhash has been tested already, that would be my preferred option. You've also shown that replacing this in the future is straightforward, if we need to. |
|
Merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cut out of #167 and a effort to address #300, originally suggested by @trishume. Removed scroll detection for simplicity at the moment.
After switching to wyhash, CPU usage is reduced by 1/2 to 1/3. I think there is more room to reduce using other hash algorithm with hardware acceleration.