Full disabling chansrv

[klewerus]

Hi!
We use xrdp with Xorg on FreeBSD server (70 users sessions). All good, but.
While begining connection we have 16 seconds freeze (black screen) before window manager dispayed to user and all other works well.

xrdp.ini:
allow_channels=false

xrdp.log:
[20190201-15:29:27] [INFO ] Socket 11: AF_INET6 connection received from ::ffff:192.168.2.20 port 40635
...
[20190201-15:29:27] [DEBUG] Info - All channels are disabled
...
[20190201-15:29:29] [DEBUG] xrdp_wm_log_msg: connected ok
[20190201-15:29:33] [ERROR] xrdp_mm_connect_chansrv: connect failed trying again...
[20190201-15:29:33] [DEBUG] Closed socket 17 (AF_UNIX)
[20190201-15:29:37] [ERROR] xrdp_mm_connect_chansrv: connect failed trying again...
[20190201-15:29:37] [DEBUG] Closed socket 17 (AF_UNIX)
[20190201-15:29:41] [ERROR] xrdp_mm_connect_chansrv: connect failed trying again...
[20190201-15:29:41] [DEBUG] Closed socket 17 (AF_UNIX)
[20190201-15:29:45] [ERROR] xrdp_mm_connect_chansrv: connect failed trying again...
[20190201-15:29:45] [ERROR] xrdp_mm_connect_chansrv: error in trans_connect chan
[20190201-15:29:45] [DEBUG] Closed socket 15 (AF_INET6 ::1 port 44852)

Оur suggestion is xrdp not to contact the chansrv at all.
If it is disabled in the settings (allow_channels=false).
Because it does not work by default on FreeBSD.

[metalefty]

What do you mean "it does not work by default on FreeBSD"? Clipboard works.

[metalefty]

BTW, it sounds reasonable not to connect chansrv if all channnels disabled. Worth considering.

[klewerus]

Yes, my mistake. In our configuration chansrv not running and chansrv sockets not creating at all (and its normal for us).

Yes, it sounds reasonable: not to connect chansrv if all channnels disabled.

[metalefty]

Besides, the root cause is "sometimes xrdp fails to connect to chansrv and have wait you" and some other people encounter the issue (ex #1286). Not to connect to chansrv is just a workaround.

[klewerus]

Please do it: not to connect chansrv if all channnels disabled. This will solve our problem.

[metalefty]

At least I will work on either.

[klewerus]

Is the problem fixed in the latest release?

[metalefty]

@jsorg71 any concerns implementing "not to connect chansrv if all channels disabled"?

[klewerus]

That's work:
./xrdp/xrdp_mm.c 1569:
+if (self->wm->client_info->channels_allowed == 1)
+{
xrdp_mm_update_allowed_channels(self);
xrdp_mm_connect_chansrv(self, ip, port);
+}

[metalefty]

Not only there. I'll make a PR.

[metalefty]

Hello again @klewerus, this issue should be solved.
Can you confirm if the issue is solved by upgrading pulseaudio-module-xrdp to 0.4_1?

I believe disabling chansrv no longer required, it should work fine.

[metalefty]

Here's the FreeBSD commit: https://svnweb.freebsd.org/ports?view=revision&revision=517939

[klewerus]

Hello.

No, issue still exists.
We still have 16 seconds freeze with pulseaudio-module-xrdp-0.4_1 and xrdp-0.9.11

[20191120-20:45:03] [ERROR] xrdp_mm_connect_chansrv: connect failed trying again...
[20191120-20:45:03] [DEBUG] Closed socket 20 (AF_UNIX)
[20191120-20:45:07] [ERROR] xrdp_mm_connect_chansrv: connect failed trying again...
[20191120-20:45:07] [DEBUG] Closed socket 20 (AF_UNIX)
[20191120-20:45:11] [ERROR] xrdp_mm_connect_chansrv: connect failed trying again...
[20191120-20:45:11] [DEBUG] Closed socket 20 (AF_UNIX)
[20191120-20:45:15] [ERROR] xrdp_mm_connect_chansrv: connect failed trying again...
[20191120-20:45:15] [ERROR] xrdp_mm_connect_chansrv: error in trans_connect chan

Waiting for new release with commit f37faca