Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged WTMP changes back in and fixed reconnect IP logging #1408

Closed
wants to merge 3 commits into from

Conversation

Jonesb
Copy link

@Jonesb Jonesb commented Sep 6, 2019

Merged #1077 back in to the devel and added logging on reconnection from new ipaddresses

This was referenced Sep 9, 2019
PIDFile=/var/run/xrdp.pid
EnvironmentFile=-/etc/sysconfig/xrdp
EnvironmentFile=-/etc/default/xrdp
ExecStart=/usr/local/sbin/xrdp $XRDP_OPTIONS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not hardcode /usr/local.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the file as its get build at compile time


[Service]
Type=forking
PIDFile=/var/run/xrdp.pid
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hardcode

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the file as its get build at compile time


[Service]
Type=forking
PIDFile=/var/run/xrdp-sesman.pid
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hardcode

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the file as its get build at compile time

EnvironmentFile=-/etc/sysconfig/xrdp
EnvironmentFile=-/etc/default/xrdp
ExecStart=/usr/local/sbin/xrdp-sesman $SESMAN_OPTIONS
ExecStop=/usr/local/sbin/xrdp-sesman $SESMAN_OPTIONS --kill
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hardcode

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the file as its get build at compile time

File gets generated at compile time
File gets created at compile time
@shaneforsythe
Copy link

All checks now show as passed, can this be merged back in? For audit/compliance purposes this is a greatly needed feature.

@moobyfr
Copy link
Contributor

moobyfr commented Nov 2, 2019

Hello,
I've tried your PR. working as excepted but I don't see "logging on reconnection from new ipaddresses" : Where is is logged ? in utmp/wtmp ?

(I'm unable to have xrdp-sesman running if I don't use the nodaemon switch)

@Jonesb
Copy link
Author

Jonesb commented Nov 2, 2019

Hello, ...

@moobyfr yes you should see the new ipaddress in wtmp on reconnection.

Sent with GitHawk

@kelliott55
Copy link

Hi @metalefty, can this PR be merged please?

@kickers56
Copy link

Hi all,
How exactly do I get the write to utmp to work? I am using xrdp 0.9.12 on ubuntu 20.04. Any help much appreciated as I need to get my login seen by the system so I can set a user login limit

@maartenb
Copy link

maartenb commented Dec 21, 2020

Hi @metalefty, can this pull be merged? It's key feature for multi-user roll-out.

@metalefty
Copy link
Member

This should be redone after #1961. There's very few chance to get merged with current authentication architecture.

@metalefty metalefty closed this Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants