-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase GFX output buffer size #2969
Conversation
Size the GFX output buffer pessimistically based on the largest monitor in the configuration.
The patch 1) works great for me. |
Can this be merged? This is needed for v0.10 to continue the user acceptance test. |
If it's needed for user acceptance testing, I think we should merge it as you suggest. |
I think @jsorg71 was investigating an anomaly that this shouldn't be necessary; but if it fixes a user facing issue then we should still merge it. No objections here. |
@matt335672 I think we still need this fix. I just want to figure out why it crashed instead of just returning a few less tiles. |
Thanks, merging and will cherry-pick to v0.10. |
Agreed that this needs more investigation. I've re-opened the original fault report which was closed automatically. @jsorg71 - I don't have a 4k monitor either, but I managed to frig something with the console on a windows VM which was bigger than my virtual monitor. Also, I think that you can probably just edit a mstsc ini file which isn't full sceen, and just put the larger dimensions in. I don't have access to an environment to check this today though. |
Thanks Matt, I can repro and I found the issue. I'll test a couple of days, then do a PR. |
Fixes #2968
Size the GFX output buffer pessimistically based on the largest monitor in the configuration.
A couple of comments:-
Because of 2) above, this is still in draft.