forked from cosmos/cosmos-sdk
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
3096412
commit b3a7717
Showing
1 changed file
with
130 additions
and
130 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,130 +1,130 @@ | ||
package keeper_test | ||
|
||
import ( | ||
"fmt" | ||
"testing" | ||
|
||
tmproto "github.com/cometbft/cometbft/proto/tendermint/types" | ||
"github.com/stretchr/testify/require" | ||
|
||
"github.com/cosmos/cosmos-sdk/simapp" | ||
sdk "github.com/cosmos/cosmos-sdk/types" | ||
"github.com/cosmos/cosmos-sdk/x/bank/keeper" | ||
"github.com/cosmos/cosmos-sdk/x/bank/types" | ||
|
||
stakingtypes "github.com/cosmos/cosmos-sdk/x/staking/types" | ||
) | ||
|
||
var _ types.BankHooks = &MockBankHooksReceiver{} | ||
|
||
// BankHooks event hooks for bank (noalias) | ||
type MockBankHooksReceiver struct{} | ||
|
||
// Mock BlockBeforeSend bank hook that doesn't allow the sending of exactly 100 coins of any denom. | ||
func (h *MockBankHooksReceiver) BlockBeforeSend(ctx sdk.Context, from, to sdk.AccAddress, amount sdk.Coins) error { | ||
for _, coin := range amount { | ||
if coin.Amount.Equal(sdk.NewInt(100)) { | ||
return fmt.Errorf("not allowed; expected %v, got: %v", 100, coin.Amount) | ||
} | ||
} | ||
return nil | ||
} | ||
|
||
// variable for counting `TrackBeforeSend` | ||
var ( | ||
countTrackBeforeSend = 0 | ||
expNextCount = 1 | ||
) | ||
|
||
// Mock TrackBeforeSend bank hook that simply tracks the sending of exactly 50 coins of any denom. | ||
func (h *MockBankHooksReceiver) TrackBeforeSend(ctx sdk.Context, from, to sdk.AccAddress, amount sdk.Coins) { | ||
for _, coin := range amount { | ||
if coin.Amount.Equal(sdk.NewInt(50)) { | ||
countTrackBeforeSend += 1 | ||
} | ||
} | ||
} | ||
|
||
func TestHooks(t *testing.T) { | ||
app := simapp.Setup(t, false) | ||
ctx := app.BaseApp.NewContext(false, tmproto.Header{}) | ||
|
||
addrs := simapp.AddTestAddrsIncremental(app, ctx, 2, sdk.NewInt(1000)) | ||
simapp.FundModuleAccount(app.BankKeeper, ctx, stakingtypes.BondedPoolName, sdk.NewCoins(sdk.NewCoin(app.StakingKeeper.BondDenom(ctx), sdk.NewInt(1000)))) | ||
|
||
// create a valid send amount which is 1 coin, and an invalidSendAmount which is 100 coins | ||
validSendAmount := sdk.NewCoins(sdk.NewCoin(app.StakingKeeper.BondDenom(ctx), sdk.NewInt(1))) | ||
triggerTrackSendAmount := sdk.NewCoins(sdk.NewCoin(app.StakingKeeper.BondDenom(ctx), sdk.NewInt(50))) | ||
invalidBlockSendAmount := sdk.NewCoins(sdk.NewCoin(app.StakingKeeper.BondDenom(ctx), sdk.NewInt(100))) | ||
|
||
// setup our mock bank hooks receiver that prevents the send of 100 coins | ||
bankHooksReceiver := MockBankHooksReceiver{} | ||
baseBankKeeper, ok := app.BankKeeper.(keeper.BaseKeeper) | ||
require.True(t, ok) | ||
keeper.UnsafeSetHooks( | ||
&baseBankKeeper, types.NewMultiBankHooks(&bankHooksReceiver), | ||
) | ||
app.BankKeeper = baseBankKeeper | ||
|
||
// try sending a validSendAmount and it should work | ||
err := app.BankKeeper.SendCoins(ctx, addrs[0], addrs[1], validSendAmount) | ||
require.NoError(t, err) | ||
|
||
// try sending an trigger track send amount and it should work | ||
err = app.BankKeeper.SendCoins(ctx, addrs[0], addrs[1], triggerTrackSendAmount) | ||
require.NoError(t, err) | ||
|
||
require.Equal(t, countTrackBeforeSend, expNextCount) | ||
expNextCount++ | ||
|
||
// try sending an invalidSendAmount and it should not work | ||
err = app.BankKeeper.SendCoins(ctx, addrs[0], addrs[1], invalidBlockSendAmount) | ||
require.Error(t, err) | ||
|
||
// make sure that account to module doesn't bypass hook | ||
err = app.BankKeeper.SendCoinsFromAccountToModule(ctx, addrs[0], stakingtypes.BondedPoolName, validSendAmount) | ||
require.NoError(t, err) | ||
err = app.BankKeeper.SendCoinsFromAccountToModule(ctx, addrs[0], stakingtypes.BondedPoolName, invalidBlockSendAmount) | ||
require.Error(t, err) | ||
err = app.BankKeeper.SendCoinsFromAccountToModule(ctx, addrs[0], stakingtypes.BondedPoolName, triggerTrackSendAmount) | ||
require.Equal(t, countTrackBeforeSend, expNextCount) | ||
expNextCount++ | ||
|
||
// make sure that module to account doesn't bypass hook | ||
err = app.BankKeeper.SendCoinsFromModuleToAccount(ctx, stakingtypes.BondedPoolName, addrs[0], validSendAmount) | ||
require.NoError(t, err) | ||
err = app.BankKeeper.SendCoinsFromModuleToAccount(ctx, stakingtypes.BondedPoolName, addrs[0], invalidBlockSendAmount) | ||
require.Error(t, err) | ||
err = app.BankKeeper.SendCoinsFromModuleToAccount(ctx, stakingtypes.BondedPoolName, addrs[0], triggerTrackSendAmount) | ||
require.Equal(t, countTrackBeforeSend, expNextCount) | ||
expNextCount++ | ||
|
||
// make sure that module to module doesn't bypass hook | ||
err = app.BankKeeper.SendCoinsFromModuleToModule(ctx, stakingtypes.BondedPoolName, stakingtypes.NotBondedPoolName, validSendAmount) | ||
require.NoError(t, err) | ||
err = app.BankKeeper.SendCoinsFromModuleToModule(ctx, stakingtypes.BondedPoolName, stakingtypes.NotBondedPoolName, invalidBlockSendAmount) | ||
// there should be no error since module to module does not call block before send hooks | ||
require.NoError(t, err) | ||
err = app.BankKeeper.SendCoinsFromModuleToModule(ctx, stakingtypes.BondedPoolName, stakingtypes.NotBondedPoolName, triggerTrackSendAmount) | ||
require.Equal(t, countTrackBeforeSend, expNextCount) | ||
expNextCount++ | ||
|
||
// make sure that DelegateCoins doesn't bypass the hook | ||
err = app.BankKeeper.DelegateCoins(ctx, addrs[0], app.AccountKeeper.GetModuleAddress(stakingtypes.BondedPoolName), validSendAmount) | ||
require.NoError(t, err) | ||
err = app.BankKeeper.DelegateCoins(ctx, addrs[0], app.AccountKeeper.GetModuleAddress(stakingtypes.BondedPoolName), invalidBlockSendAmount) | ||
require.Error(t, err) | ||
err = app.BankKeeper.DelegateCoins(ctx, addrs[0], app.AccountKeeper.GetModuleAddress(stakingtypes.BondedPoolName), triggerTrackSendAmount) | ||
require.Equal(t, countTrackBeforeSend, expNextCount) | ||
expNextCount++ | ||
|
||
// make sure that UndelegateCoins doesn't bypass the hook | ||
err = app.BankKeeper.UndelegateCoins(ctx, app.AccountKeeper.GetModuleAddress(stakingtypes.BondedPoolName), addrs[0], validSendAmount) | ||
require.NoError(t, err) | ||
err = app.BankKeeper.UndelegateCoins(ctx, app.AccountKeeper.GetModuleAddress(stakingtypes.BondedPoolName), addrs[0], invalidBlockSendAmount) | ||
require.Error(t, err) | ||
|
||
err = app.BankKeeper.UndelegateCoins(ctx, app.AccountKeeper.GetModuleAddress(stakingtypes.BondedPoolName), addrs[0], triggerTrackSendAmount) | ||
require.Equal(t, countTrackBeforeSend, expNextCount) | ||
expNextCount++ | ||
} | ||
//package keeper_test | ||
// | ||
//import ( | ||
// "fmt" | ||
// "testing" | ||
// | ||
// tmproto "github.com/cometbft/cometbft/proto/tendermint/types" | ||
// "github.com/stretchr/testify/require" | ||
// | ||
// "github.com/cosmos/cosmos-sdk/simapp" | ||
// sdk "github.com/cosmos/cosmos-sdk/types" | ||
// "github.com/cosmos/cosmos-sdk/x/bank/keeper" | ||
// "github.com/cosmos/cosmos-sdk/x/bank/types" | ||
// | ||
// stakingtypes "github.com/cosmos/cosmos-sdk/x/staking/types" | ||
//) | ||
// | ||
//var _ types.BankHooks = &MockBankHooksReceiver{} | ||
// | ||
//// BankHooks event hooks for bank (noalias) | ||
//type MockBankHooksReceiver struct{} | ||
// | ||
//// Mock BlockBeforeSend bank hook that doesn't allow the sending of exactly 100 coins of any denom. | ||
//func (h *MockBankHooksReceiver) BlockBeforeSend(ctx sdk.Context, from, to sdk.AccAddress, amount sdk.Coins) error { | ||
// for _, coin := range amount { | ||
// if coin.Amount.Equal(sdk.NewInt(100)) { | ||
// return fmt.Errorf("not allowed; expected %v, got: %v", 100, coin.Amount) | ||
// } | ||
// } | ||
// return nil | ||
//} | ||
// | ||
//// variable for counting `TrackBeforeSend` | ||
//var ( | ||
// countTrackBeforeSend = 0 | ||
// expNextCount = 1 | ||
//) | ||
// | ||
//// Mock TrackBeforeSend bank hook that simply tracks the sending of exactly 50 coins of any denom. | ||
//func (h *MockBankHooksReceiver) TrackBeforeSend(ctx sdk.Context, from, to sdk.AccAddress, amount sdk.Coins) { | ||
// for _, coin := range amount { | ||
// if coin.Amount.Equal(sdk.NewInt(50)) { | ||
// countTrackBeforeSend += 1 | ||
// } | ||
// } | ||
//} | ||
// | ||
//func TestHooks(t *testing.T) { | ||
// app := simapp.Setup(t, false) | ||
// ctx := app.BaseApp.NewContext(false, tmproto.Header{}) | ||
// | ||
// addrs := simapp.AddTestAddrsIncremental(app, ctx, 2, sdk.NewInt(1000)) | ||
// simapp.FundModuleAccount(app.BankKeeper, ctx, stakingtypes.BondedPoolName, sdk.NewCoins(sdk.NewCoin(app.StakingKeeper.BondDenom(ctx), sdk.NewInt(1000)))) | ||
// | ||
// // create a valid send amount which is 1 coin, and an invalidSendAmount which is 100 coins | ||
// validSendAmount := sdk.NewCoins(sdk.NewCoin(app.StakingKeeper.BondDenom(ctx), sdk.NewInt(1))) | ||
// triggerTrackSendAmount := sdk.NewCoins(sdk.NewCoin(app.StakingKeeper.BondDenom(ctx), sdk.NewInt(50))) | ||
// invalidBlockSendAmount := sdk.NewCoins(sdk.NewCoin(app.StakingKeeper.BondDenom(ctx), sdk.NewInt(100))) | ||
// | ||
// // setup our mock bank hooks receiver that prevents the send of 100 coins | ||
// bankHooksReceiver := MockBankHooksReceiver{} | ||
// baseBankKeeper, ok := app.BankKeeper.(keeper.BaseKeeper) | ||
// require.True(t, ok) | ||
// keeper.UnsafeSetHooks( | ||
// &baseBankKeeper, types.NewMultiBankHooks(&bankHooksReceiver), | ||
// ) | ||
// app.BankKeeper = baseBankKeeper | ||
// | ||
// // try sending a validSendAmount and it should work | ||
// err := app.BankKeeper.SendCoins(ctx, addrs[0], addrs[1], validSendAmount) | ||
// require.NoError(t, err) | ||
// | ||
// // try sending an trigger track send amount and it should work | ||
// err = app.BankKeeper.SendCoins(ctx, addrs[0], addrs[1], triggerTrackSendAmount) | ||
// require.NoError(t, err) | ||
// | ||
// require.Equal(t, countTrackBeforeSend, expNextCount) | ||
// expNextCount++ | ||
// | ||
// // try sending an invalidSendAmount and it should not work | ||
// err = app.BankKeeper.SendCoins(ctx, addrs[0], addrs[1], invalidBlockSendAmount) | ||
// require.Error(t, err) | ||
// | ||
// // make sure that account to module doesn't bypass hook | ||
// err = app.BankKeeper.SendCoinsFromAccountToModule(ctx, addrs[0], stakingtypes.BondedPoolName, validSendAmount) | ||
// require.NoError(t, err) | ||
// err = app.BankKeeper.SendCoinsFromAccountToModule(ctx, addrs[0], stakingtypes.BondedPoolName, invalidBlockSendAmount) | ||
// require.Error(t, err) | ||
// err = app.BankKeeper.SendCoinsFromAccountToModule(ctx, addrs[0], stakingtypes.BondedPoolName, triggerTrackSendAmount) | ||
// require.Equal(t, countTrackBeforeSend, expNextCount) | ||
// expNextCount++ | ||
// | ||
// // make sure that module to account doesn't bypass hook | ||
// err = app.BankKeeper.SendCoinsFromModuleToAccount(ctx, stakingtypes.BondedPoolName, addrs[0], validSendAmount) | ||
// require.NoError(t, err) | ||
// err = app.BankKeeper.SendCoinsFromModuleToAccount(ctx, stakingtypes.BondedPoolName, addrs[0], invalidBlockSendAmount) | ||
// require.Error(t, err) | ||
// err = app.BankKeeper.SendCoinsFromModuleToAccount(ctx, stakingtypes.BondedPoolName, addrs[0], triggerTrackSendAmount) | ||
// require.Equal(t, countTrackBeforeSend, expNextCount) | ||
// expNextCount++ | ||
// | ||
// // make sure that module to module doesn't bypass hook | ||
// err = app.BankKeeper.SendCoinsFromModuleToModule(ctx, stakingtypes.BondedPoolName, stakingtypes.NotBondedPoolName, validSendAmount) | ||
// require.NoError(t, err) | ||
// err = app.BankKeeper.SendCoinsFromModuleToModule(ctx, stakingtypes.BondedPoolName, stakingtypes.NotBondedPoolName, invalidBlockSendAmount) | ||
// // there should be no error since module to module does not call block before send hooks | ||
// require.NoError(t, err) | ||
// err = app.BankKeeper.SendCoinsFromModuleToModule(ctx, stakingtypes.BondedPoolName, stakingtypes.NotBondedPoolName, triggerTrackSendAmount) | ||
// require.Equal(t, countTrackBeforeSend, expNextCount) | ||
// expNextCount++ | ||
// | ||
// // make sure that DelegateCoins doesn't bypass the hook | ||
// err = app.BankKeeper.DelegateCoins(ctx, addrs[0], app.AccountKeeper.GetModuleAddress(stakingtypes.BondedPoolName), validSendAmount) | ||
// require.NoError(t, err) | ||
// err = app.BankKeeper.DelegateCoins(ctx, addrs[0], app.AccountKeeper.GetModuleAddress(stakingtypes.BondedPoolName), invalidBlockSendAmount) | ||
// require.Error(t, err) | ||
// err = app.BankKeeper.DelegateCoins(ctx, addrs[0], app.AccountKeeper.GetModuleAddress(stakingtypes.BondedPoolName), triggerTrackSendAmount) | ||
// require.Equal(t, countTrackBeforeSend, expNextCount) | ||
// expNextCount++ | ||
// | ||
// // make sure that UndelegateCoins doesn't bypass the hook | ||
// err = app.BankKeeper.UndelegateCoins(ctx, app.AccountKeeper.GetModuleAddress(stakingtypes.BondedPoolName), addrs[0], validSendAmount) | ||
// require.NoError(t, err) | ||
// err = app.BankKeeper.UndelegateCoins(ctx, app.AccountKeeper.GetModuleAddress(stakingtypes.BondedPoolName), addrs[0], invalidBlockSendAmount) | ||
// require.Error(t, err) | ||
// | ||
// err = app.BankKeeper.UndelegateCoins(ctx, app.AccountKeeper.GetModuleAddress(stakingtypes.BondedPoolName), addrs[0], triggerTrackSendAmount) | ||
// require.Equal(t, countTrackBeforeSend, expNextCount) | ||
// expNextCount++ | ||
//} | ||
Check failure on line 130 in x/bank/keeper/hooks_test.go GitHub Actions / dependency-review
Check failure on line 130 in x/bank/keeper/hooks_test.go GitHub Actions / dependency-review
Check failure on line 130 in x/bank/keeper/hooks_test.go GitHub Actions / golangci-lint
|