Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clean staking error #ntrn-443 #222

Merged
merged 7 commits into from
May 25, 2023
Merged

fix: clean staking error #ntrn-443 #222

merged 7 commits into from
May 25, 2023

Conversation

NeverHappened
Copy link
Contributor

changes in wasmd module: neutron-org/wasmd@67da724

@NeverHappened NeverHappened self-assigned this Apr 26, 2023
@NeverHappened
Copy link
Contributor Author

https://github.com/neutron-org/neutron-tests/actions/runs/4828287277

foxpy
foxpy approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@foxpy foxpy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit, but I've never tested it. It may be overkill, but we could make an integration test for this.

@sotnikov-s
Copy link
Contributor

sotnikov-s commented May 23, 2023 •
edited

Looks legit, but I've never tested it. It may be overkill, but we could make an integration test for this.

neutron-org/neutron-integration-tests#145
neutron-org/neutron-dev-contracts#17

@oopcode note when merging

@zavgorodnii zavgorodnii merged commit 3a6cf82 into main May 25, 2023
9 checks passed
@pr0n00gler pr0n00gler deleted the fix/clean-staking-error branch September 18, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foxpy foxpy foxpy approved these changes

@sotnikov-s sotnikov-s sotnikov-s approved these changes

Assignees

@NeverHappened NeverHappened

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NeverHappened @sotnikov-s @foxpy @zavgorodnii