Ensure deposit, withdraw and place/withdraw limit order correctly val… #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcompagni10
force-pushed
the
fix_tick_fee_validation
branch
from
a179c9d
to
16bc8b3
Compare
…idate inputs to ensure that abs(tick) + fee < MaxTickExp This not only provides better validation for transactins that will fail at later price checks, but also ensures that tick + fee combinations that could overflow an int64 are not allowed into the system.
jcompagni10
force-pushed
the
fix_tick_fee_validation
branch
from
16bc8b3
to
47d47db
Compare
pr0n00gler
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure deposit, withdraw and place/withdraw limit order correctly validate inputs to ensure that abs(tick) + fee < MaxTickExp