Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmosaic keyword argument not accepted in Sample class #50

Closed
js54434 opened this issue Feb 23, 2016 · 1 comment
Closed

vmosaic keyword argument not accepted in Sample class #50

js54434 opened this issue Feb 23, 2016 · 1 comment
Labels
bug

Comments

@js54434
Copy link

js54434 commented Feb 23, 2016

I'm trying to compare a different resolution matrix calculation code with the neutronpy calculation, but I'm noticing that, while vmosaic is mentioned in the source code for the Instrument class, it's not yet a part of the Sample class.
@pseudocubic
Copy link
Contributor

The calculation takes into account a vmosaic attribute of the Sample class if it has one, which you can define if you wish, but you are correct that I never explicitly included the vmosaic attribute in Sample, so I will correct that.

pseudocubic pushed a commit that referenced this issue Feb 23, 2016
FIX: Explicitly defines vmosaic in Sample class and corrects default …
9efb793 
…moncor behavior

Resolves #50
Resolves #51

Default behavior with moncor attribute unset was to normalize to source flux, opposite of what was indicated in documentation. Changed to reflect current documentation. In resolution unit tests, moncor = 0 set explicitly to prevent test failure.

Attribute for vertical mosaic of sample, vmosaic, was not explicitly defined in Sample class. Corrected to include vmosaic variable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pseudocubic @js54434