Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Anaconda and PYPI automatic deployment #109

Merged
merged 2 commits into from May 18, 2017
Merged

FIX: Anaconda and PYPI automatic deployment #109

merged 2 commits into from May 18, 2017

Conversation

pseudocubic
Copy link
Contributor

PYPI was not accepting sdist uploads based on incorrect version format. Version format was being taken directly from git describe output, giving version numbers such as 1.0.3-4-ga36bedb, which are not valid under the PEP 440 version number specification (https://www.python.org/dev/peps/pep-0440/). This was preventing upload to PYPI with twine, resulting in HTTP 400 errors.

The new auto-version format still uses git describe but now parses it so that the new version number bumps the tag version by one, and adds a dev specifier to the end which represents the number of commits the build is ahead of the previous tag. For example, if the previous tag was 1.0.3 and the current build is 5 commits ahead of the tag then the new version number will be 1.0.4.dev5

To get this version in the meta.yaml file for the conda build, I now use jinja templating with {% data = load_setup_py_data() %}

David M Fobes added 2 commits May 16, 2017 14:55
Updated conda recipe to prevent build failure
Fixed auto-version creation based on git describe to fix conda and pypi deployment scripts
@codecov-io
Copy link

Codecov Report

Merging #109 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #109   +/-   ##
======================================
  Coverage    84.8%   84.8%           
======================================
  Files          48      48           
  Lines        3941    3941           
======================================
  Hits         3342    3342           
  Misses        599     599

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a36bedb...1c2517a. Read the comment docs.

@pseudocubic pseudocubic merged commit e1ee47b into neutronpy:master May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants