Histoparams #37
Merged
Histoparams #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on value and colinear check among them; code from mantid --> DimensionSelectorWidget.py
…ground colors set to red and fields are cleared for step that are not allowed to have values. Step values can be positive double numbers with a standard notation using built-in validators.
…lue as the selected one is updated with the selected ones previous value to ensure uniqueness. min and max values are checked to be float numbers, both (not) exist and min less than max
…am button click-submission a dictioary with all the histogram parameters is created
…onay creation in histogram button and projections values
…wn added and valid states for projections and min-max value pairs
…e mandit script, tests added, steps mandatory based on radio buttons with their tests
rosswhitfield
requested changes
Mar 22, 2023
…checks with mandit apis
for more information, see https://pre-commit.ci
…mments, symmetry string split into 2 lines
…s tfor pre-commit script
…th pre-commit script
rosswhitfield
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Histogram Parameters.
Updates in Views/ and Models/ for the histogram parameters tab. Some functionality is taken from mantid --> DimensionSelectorWidget.py. Tests are included, too.