Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MDE menu options #38

Merged
merged 2 commits into from
Mar 23, 2023
Merged

Add MDE menu options #38

merged 2 commits into from
Mar 23, 2023

Conversation

rosswhitfield
Copy link
Member

@rosswhitfield rosswhitfield commented Mar 22, 2023

This adds the following right-click menu options

  • Set as data
  • Set as background/Unset as background
  • Rename
  • Delete

MDE_menu

Currently, I am just using some existing QT icon to mark data and background, these will be changed later to some custom icons. Green arrow is data, black is background.

TO DO (in a later PR):

  • change icons used to mark data and background
  • add tests

594

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #38 (f9d2839) into next (3a53868) will decrease coverage by 4.75%.
The diff coverage is 48.20%.

@@            Coverage Diff             @@
##             next      #38      +/-   ##
==========================================
- Coverage   79.21%   74.47%   -4.75%     
==========================================
  Files          12       13       +1     
  Lines         765      854      +89     
==========================================
+ Hits          606      636      +30     
- Misses        159      218      +59     
Impacted Files Coverage Δ
src/shiver/views/histogram_parameters.py 95.72% <ø> (-0.02%) ⬇️
src/shiver/views/workspace_tables.py 44.26% <44.26%> (ø)
src/shiver/models/histogram.py 59.28% <66.66%> (-0.28%) ⬇️
src/shiver/presenters/histogram.py 64.70% <66.66%> (+0.42%) ⬆️
src/shiver/views/histogram.py 73.52% <100.00%> (+2.47%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@mpatrou mpatrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test scenario conducted used the file: merged_mde_MnO_25meV_5K_unpol_178921-178926.nxs. It was added several times with different names (Rename action). The various mde workspaces were set/unset background, data and deleted, by selecting the corresponding choices.

mde_dropdown

@rosswhitfield rosswhitfield merged commit c55f378 into next Mar 23, 2023
@rosswhitfield rosswhitfield deleted the mde_menu branch March 23, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants