Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add correction table #43

Merged
merged 24 commits into from
Mar 30, 2023
Merged

Add correction table #43

merged 24 commits into from
Mar 30, 2023

Conversation

KedoKudo
Copy link
Member

Description

This PR introduces the following changes:

  • add correction table for MDE workspaces
  • add corresponding unit test

Testing instruction

  • clone the feature branch and perform editable install with pip (see readme.md)
  • start the application by typing shiver in the CML
  • happy path
    • load an mde workspace
    • right click and select set corrections
      image
    • config the correction table to match below
      image
    • hit Apply or enter on the keyboard
  • a new workspace should be visible from the mde list, and the correction tab should be gone automatically
    image

IBM work item: Story588

@KedoKudo KedoKudo self-assigned this Mar 28, 2023
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #43 (3286e2c) into next (3b8a313) will increase coverage by 1.25%.
The diff coverage is 88.37%.

@@            Coverage Diff             @@
##             next      #43      +/-   ##
==========================================
+ Coverage   81.70%   82.96%   +1.25%     
==========================================
  Files          13       15       +2     
  Lines         924     1139     +215     
==========================================
+ Hits          755      945     +190     
- Misses        169      194      +25     
Impacted Files Coverage Δ
src/shiver/models/histogram.py 60.00% <ø> (ø)
src/shiver/models/corrections.py 77.27% <77.27%> (ø)
src/shiver/presenters/histogram.py 83.78% <100.00%> (+19.07%) ⬆️
src/shiver/views/corrections.py 100.00% <100.00%> (ø)
src/shiver/views/histogram.py 86.04% <100.00%> (+0.68%) ⬆️
src/shiver/views/workspace_tables.py 89.23% <100.00%> (+0.70%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

src/shiver/views/corrections.py Outdated Show resolved Hide resolved
Copy link
Member

@AndreiSavici AndreiSavici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the tab should remember which are the new corrections that should be applied. For example, say I am working on a workspace that already had DB applied. It will show up with the button checked and disabled. So if the button is disabled, I should ignore it in the apply function

src/shiver/models/corrections.py Outdated Show resolved Hide resolved
src/shiver/presenters/histogram.py Outdated Show resolved Hide resolved
src/shiver/models/corrections.py Outdated Show resolved Hide resolved
@KedoKudo KedoKudo disabled auto-merge March 30, 2023 16:26
@KedoKudo KedoKudo enabled auto-merge March 30, 2023 16:26
@KedoKudo KedoKudo dismissed rosswhitfield’s stale review March 30, 2023 16:27

the requested refactoring has been performed

@KedoKudo KedoKudo merged commit 79a34be into next Mar 30, 2023
4 checks passed
@KedoKudo KedoKudo deleted the item588_correction branch March 30, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants