Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dead time #85

Draft
wants to merge 5 commits into
base: next
Choose a base branch
from
Draft

add dead time #85

wants to merge 5 commits into from

Conversation

mdoucet
Copy link
Member

@mdoucet mdoucet commented May 7, 2024

Add dead time.

The option is currently set to True. Should add a settings panel like we did for refred

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2024

Codecov Report

Attention: Patch coverage is 44.31818% with 98 lines in your changes missing coverage. Please review.

Project coverage is 35.49%. Comparing base (04e625c) to head (2d32bcc).
Report is 20 commits behind head on next.

Current head 2d32bcc differs from pull request most recent head 23f9b00

Please upload reports for the commit 23f9b00 to get more accurate results.

Files Patch % Lines
..._ui/interfaces/data_handling/DeadTimeCorrection.py 22.41% 45 Missing ⚠️
...ectivity_ui/interfaces/data_handling/instrument.py 10.00% 36 Missing ⚠️
reflectivity_ui/ui/deadtime_settings.py 57.69% 11 Missing ⚠️
reflectivity_ui/interfaces/main_window.py 61.53% 5 Missing ⚠️
...flectivity_ui/interfaces/data_handling/data_set.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next      #85      +/-   ##
==========================================
+ Coverage   35.28%   35.49%   +0.21%     
==========================================
  Files          30       33       +3     
  Lines        6054     6260     +206     
==========================================
+ Hits         2136     2222      +86     
- Misses       3918     4038     +120     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdoucet mdoucet marked this pull request as draft May 7, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants