Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 2 support #60

Closed
adi- opened this issue Apr 23, 2017 · 2 comments
Closed

Drop python 2 support #60

adi- opened this issue Apr 23, 2017 · 2 comments

Comments

@adi-
Copy link
Member

adi- commented Apr 23, 2017

Django 2.0 is removing Python 2.x support, so as we should do...

@ezarowny
Copy link
Contributor

From #105:

For uploads, I noticed that using django-markdownx with something like django-storages doesn't work because the image stream position is set to the end of the steam when the InMemoryUploadedFile is instantiated. Simply resetting the image stream position back to the beginning should do the trick.

In the future, when you guys drop Python 2 support, something like getbuffer or getvalue could be used to get the length of the buffer instead of using tell.

@adi-
Copy link
Member Author

adi- commented Dec 26, 2019

Already in master

@adi- adi- closed this as completed Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants