Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .wrl support #185

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add .wrl support #185

wants to merge 3 commits into from

Conversation

Toctave
Copy link

@Toctave Toctave commented Dec 7, 2023

As the title says, this PR adds basic WRL support. I've done only the bare minimum, so there aren't any import options for instance. That being said, in the long run it would perhaps be better to somehow inherit the import UI from each import format rather than recreating it in the add-on.

@Toctave Toctave changed the title Add .x3d/.wrl support Add .wrl support Dec 7, 2023
@neverhood311
Copy link
Owner

What's the difference between WRL and X3D? Why did you remove all mentions of X3D? (I'm most familiar with OBJ, PLY, and STL, so I don't know much about X3D)

@Toctave
Copy link
Author

Toctave commented Dec 7, 2023

I don't really know the difference actually (not an X3D expert either, I just wrote this change for a coworker who needed to visualize .wrl sequences).

Blender has the same importer for both file extensions, hence why I initially mentioned "X3D/WRL" everywhere, but due to how your add-on currently scans for files I needed to have a single file extension, hence I figured I'd go with .wrl everywhere first and then maybe add .x3d back in.

I'll give the X3D/WRL thing a quick look and let you know.

@neverhood311
Copy link
Owner

Blender has the same importer for both file extensions, hence why I initially mentioned "X3D/WRL" everywhere, but due to how your add-on currently scans for files I needed to have a single file extension, hence I figured I'd go with .wrl everywhere first and then maybe add .x3d back in.

Interesting. That's a good catch

Also, I've already added this feature (x3d at least) to v2.2.0. See #144. You might want to start your branch from there instead of from master.

@Toctave
Copy link
Author

Toctave commented Dec 8, 2023

Oh, ok, thanks! How come the branch with the most recent changes is not the default one ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants