still some more coverage

nevermined-io · May 24, 2022 · f875206 · f875206
1 parent bf89f91
commit f875206
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 13 deletions.
diff --git a/contracts/conditions/LockPaymentCondition.sol b/contracts/conditions/LockPaymentCondition.sol
@@ -316,23 +316,13 @@ contract LockPaymentCondition is ILockPayment, ReentrancyGuardUpgradeable, Condi
     }
 
    /**
-    * @notice _transferERC20 transfer ERC20 tokens 
+    * @notice _transferERC20Proxy transfer ERC20 tokens 
+    * @param _senderAddress the address to send the tokens from
     * @param _rewardAddress the address to receive the tokens
     * @param _tokenAddress the ERC20 contract address to use during the payment
     * @param _amount token amount to be locked/released
     * @dev Will throw if transfer fails
     */
-    function _transferERC20(
-        address _rewardAddress,
-        address _tokenAddress,
-        uint256 _amount
-    )
-    internal
-    {
-        IERC20Upgradeable token = ERC20Upgradeable(_tokenAddress);
-        token.safeTransferFrom(msg.sender, _rewardAddress, _amount);
-    }
-
     function _transferERC20Proxy(
         address _senderAddress,
         address _rewardAddress,

diff --git a/test/unit/registry/DIDRegistry.Test.js b/test/unit/registry/DIDRegistry.Test.js
@@ -639,11 +639,19 @@ contract('DIDRegistry', (accounts) => {
                 'hi there'
             )
 
-            didRegistry.addDIDProvenanceDelegate(did, someone)
+            await didRegistry.addDIDProvenanceDelegate(did, someone)
 
             await didRegistry.used(testUtils.generateId(), did, owner, Activities.USED, [], '', {
                 from: someone
             })
+
+            await didRegistry.removeDIDProvenanceDelegate(did, someone)
+
+            await assert.isRejected(
+                didRegistry.used(testUtils.generateId(), did, owner, Activities.USED, [], '', { from: someone }),
+                ''
+            )
+
         })
 
         it('should fail to use an entity from someone', async () => {