We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The CONDITION_TYPE & MARKET_ROLE variables are meant to be usable internally in the system.
CONDITION_TYPE
MARKET_ROLE
bytes32 public constant CONDITION_TYPE = keccak256('TransferNFTCondition'); bytes32 public constant MARKET_ROLE = keccak256("MARKETPLACE_ROLE");
We advise them to be set as internal or private to avoid the generation of a redundant getter function.
internal
private
The text was updated successfully, but these errors were encountered:
fixed
Sorry, something went wrong.
fixes #144
9298fc8
aaitor
Successfully merging a pull request may close this issue.
TNF-02C: Redundant Visibility Specifier
Description:
The
CONDITION_TYPE
&MARKET_ROLE
variables are meant to be usable internally in the system.Example:
Recommendation:
We advise them to be set as
internal
orprivate
to avoid the generation of a redundant getter function.The text was updated successfully, but these errors were encountered: