Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant Visibility Specifier #144

Closed
aaitor opened this issue Aug 9, 2021 · 1 comment · Fixed by #145
Closed

Redundant Visibility Specifier #144

aaitor opened this issue Aug 9, 2021 · 1 comment · Fixed by #145

Comments

@aaitor
Copy link
Member

aaitor commented Aug 9, 2021

TNF-02C: Redundant Visibility Specifier

Type Severity Location
Code Style Informational TransferNFTCondition.sol:L22, L24

Description:

The CONDITION_TYPE & MARKET_ROLE variables are meant to be usable internally in the system.

Example:

bytes32 public constant CONDITION_TYPE = keccak256('TransferNFTCondition');

bytes32 public constant MARKET_ROLE = keccak256("MARKETPLACE_ROLE");

Recommendation:

We advise them to be set as internal or private to avoid the generation of a redundant getter function.

@aaitor
Copy link
Member Author

aaitor commented Aug 9, 2021

fixed

@aaitor aaitor linked a pull request Aug 9, 2021 that will close this issue
aaitor added a commit that referenced this issue Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant