erc721 suggestion transfer nft #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntracts into mrsmkl/erc721-suggestions
…ntracts into mrsmkl/erc721-suggestions
aaitor
reviewed
Jun 30, 2021
| ); | ||
|
|
||
| require( | ||
| _nftAmount == 0 || (_nftAmount == 1 && token.ownerOf(uint256(_did)) == _nftHolder), |
There was a problem hiding this comment.
makes sense _nftAmount==0? What would be the condition requiring an amount of 0 NFTs for transferring?
There was a problem hiding this comment.
not really, I'll check if ERC1155 safe transfer allows zero value
Edit: to have the same behaviour as the ERC1155 one, it should be noop with amount 0. But a check could be added to other contract...
aaitor
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a description of your changes here.
Is this PR related with an open issue?
Related to Issue #
Types of changes
Checklist:
Funny gif