Transfer proof #121
Merged
Transfer proof #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the POC for handling challenges https://github.com/nevermined-io/data-transfer-poc |
aaitor
approved these changes
Sep 1, 2021
| @@ -16,16 +16,19 @@ jobs: | |||
| - uses: actions/checkout@v2 | |||
| - uses: actions/setup-node@v1 | |||
| with: | |||
| node-version: '10.x' | |||
There was a problem hiding this comment.
I'm not sure about changing the node version here. Previous experiences bumping to node >=12.x created some issues.
Is node >=14.x a requirement?
There was a problem hiding this comment.
yeah, looks like snarkjs and circom depend on it...
aaitor
reviewed
Sep 1, 2021
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement the condition and agreement for access with transfer proof.
Currently the condition is pretty generic, so just access to some data perhaps should be connected to DID hash or something?
Is this PR related with an open issue?
Types of changes
Checklist:
Funny gif