Adding K-V storage to conditions allowing to implement protection between conditions #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ause upgradeability issues This reverts commit 288cc3e.
mrsmkl
reviewed
Oct 15, 2021
| @@ -138,6 +138,14 @@ contract TransferNFT721Condition is Condition, ITransferNFT, ReentrancyGuardUpgr | |||
| lockConditionState == ConditionStoreLibrary.ConditionState.Fulfilled, | |||
| 'LockCondition needs to be Fulfilled' | |||
| ); | |||
|
|
|||
| // Check that nft receiver is the same enabled in the lock payment condition | |||
| require( | |||
There was a problem hiding this comment.
Not sure this helps...
The scenario I was thinking is the following:
- TransferCondition contract is approved by LockPaymentCondition contract to transfer token
id(not certain if this can even happen currently, but for the casenftOwner == _lockConditionAddressit is needed) - Correct flow: a lock payment condition is created, and a transfer condition depending on that. The lock payment condition is fulfilled
- Attack flow: another pair of conditions is created with the attacker as receiver. Attacker fulfills the bogus lock payment condition, and then can fulfill the transfer condition as receiver.
One possible solution could be to set the receiver when the token is sent to _lockConditionAddress ...
mrsmkl
approved these changes
Oct 19, 2021
|
I'm gonna leave the Conditions Key-Value implementation there because it can be useful/necessary for some complex service agreements |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To add a better protection to fulfillment of conditions dependant on other conditions, this PR adds a KV storage related with the Condition Ids. This allow to publish parameters in the fulfillment of conditions that can be used by other conditions to validate/control the access/fulfillment.
This is implemented in the
TransferNFT721conditionIs this PR related with an open issue?
Related to Issue #
Types of changes
Checklist: