Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating to hardhat #178

Merged
merged 45 commits into from
Nov 18, 2021
Merged

Updating to hardhat #178

merged 45 commits into from
Nov 18, 2021

Conversation

mrsmkl
Copy link
Contributor

@mrsmkl mrsmkl commented Nov 2, 2021

Description

Updated unit tests.

TODO:

  • update integration tests
  • handling upgrades

Is this PR related with an open issue?

Related to Issue #

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Follows the code style of this project.
  • Tests Cover Changes
  • Documentation

Funny gif

Put a link of a funny gif inside the parenthesis-->

@mrsmkl mrsmkl requested review from a team as code owners November 2, 2021 17:29
aaitor
aaitor approved these changes Nov 16, 2021
View reviewed changes
Copy link
Member

@aaitor aaitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@aaitor aaitor linked an issue Nov 16, 2021 that may be closed by this pull request
Update to hardhat and openzeppelin >= 4.3 #177
Closed
4 tasks
@aaitor aaitor merged commit b8ccdee into master Nov 18, 2021
@aaitor aaitor deleted the feat/hardhat branch November 18, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaitor aaitor aaitor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to hardhat and openzeppelin >= 4.3
2 participants
@mrsmkl @aaitor