Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minting erc721 nfts from registry #181

Merged
merged 15 commits into from
Nov 24, 2021
Merged

Minting erc721 nfts from registry #181

merged 15 commits into from
Nov 24, 2021

Conversation

mrsmkl
Copy link
Contributor

@mrsmkl mrsmkl commented Nov 18, 2021 •
edited

Description

Refactor erc 1155 support from DIDRegistry.
Add support for erc 721.

Is this PR related with an open issue?

Related to Issue #172 #180

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Follows the code style of this project.
  • Tests Cover Changes
  • Documentation

Funny gif

Put a link of a funny gif inside the parenthesis-->

@mrsmkl mrsmkl requested review from a team as code owners November 18, 2021 09:34
@mrsmkl mrsmkl changed the base branch from master to feat/hardhat November 18, 2021 15:10
Base automatically changed from feat/hardhat to master November 18, 2021 15:42
aaitor
aaitor approved these changes Nov 23, 2021
View reviewed changes
Copy link
Member

@aaitor aaitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@aaitor aaitor linked an issue Nov 23, 2021 that may be closed by this pull request
ERC-721 full support in contracts #172
Closed
@aaitor aaitor merged commit 2163664 into master Nov 24, 2021
@aaitor aaitor deleted the feat/mint-erc721 branch November 24, 2021 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaitor aaitor aaitor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ERC-721 full support in contracts
2 participants
@mrsmkl @aaitor