Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init transfer did condition with correct contract #195

Merged
merged 5 commits into from
Dec 1, 2021
Merged

init transfer did condition with correct contract #195

merged 5 commits into from
Dec 1, 2021

Conversation

mrsmkl
Copy link
Contributor

@mrsmkl mrsmkl commented Dec 1, 2021 •
edited

Description

Also checked that nft conditions with erc721 are clean.

Is this PR related with an open issue?

Related to Issue #

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Follows the code style of this project.
  • Tests Cover Changes
  • Documentation

Funny gif

Put a link of a funny gif inside the parenthesis-->

@mrsmkl mrsmkl requested review from a team as code owners December 1, 2021 12:54
r-marques
r-marques approved these changes Dec 1, 2021
View reviewed changes
Copy link
Member

@r-marques r-marques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aaitor aaitor merged commit 819ce20 into master Dec 1, 2021
@aaitor aaitor deleted the fix/init-transfer-did branch December 1, 2021 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-marques r-marques r-marques approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mrsmkl @r-marques @aaitor