Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support to NFTs metadata (ERC-721 & 1155) #213

Merged
merged 9 commits into from
Jan 17, 2022
Merged

Adding support to NFTs metadata (ERC-721 & 1155) #213

merged 9 commits into from
Jan 17, 2022

Conversation

aaitor
Copy link
Member

@aaitor aaitor commented Jan 14, 2022

Description

  • Adding support to EIP-2981
  • Adding support to NFTs metadata (ERC-721 & 1155)
  • (fix) NFT721 test was using 1155 tokens
  • v1.3.3

Is this PR related with an open issue?

Related to Issue #209 and #212

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Follows the code style of this project.
  • Tests Cover Changes
  • Documentation

@aaitor aaitor requested review from a team as code owners January 14, 2022 13:44
@aaitor aaitor mentioned this pull request Jan 14, 2022
Closed
6 tasks
This was linked to issues Jan 14, 2022
The NFT contracts should allow to specify and retrieve the URI Metadata using the 'de-facto' marketplace standards #212
Closed
Implement EIP 2981 support into ERC 1155 and 721 NFT contracts #209
Closed
r-marques
r-marques approved these changes Jan 17, 2022
View reviewed changes
Copy link
Member

@r-marques r-marques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aaitor aaitor merged commit 90b86f0 into master Jan 17, 2022
@aaitor aaitor deleted the feature/nft_metadata branch January 17, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-marques r-marques r-marques approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@aaitor @r-marques