NFT dtp agreements #221
Merged
NFT dtp agreements #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/nft-dtp-agreements
aaitor
reviewed
Feb 3, 2022
| bytes32 _did, | ||
| address _lockAddress, | ||
| uint256 _amount, | ||
| address _receiver, |
There was a problem hiding this comment.
NFT Marked Condtion and interface looks the same than existing NFT condition and interface but without the receiver parameter. So to avoid code duplication, if receiver is necessary in the new flows, can we refactor the existing templates to include the receiver parameter? And if it's not used in some templates/flows we pass address(0)?
aaitor
reviewed
Feb 3, 2022
| * can release reward if lock and release conditions | ||
| * are fulfilled. | ||
| */ | ||
| contract MultiEscrowPaymentCondition is Reward, Common, ReentrancyGuardUpgradeable { |
There was a problem hiding this comment.
Wouldn't be possible here to implement using the existing EscrowPaymentCondition with a new method to fulfill an array of releaseConditons? Also we could keep compatibility exposing a hash/fulfill where one releaseCondition becomes an array of releaseConditions that we pass to the implementation using the array.
aaitor
approved these changes
Feb 8, 2022
…ntracts into feat/nft-dtp-agreements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added three new agreement templates
TODO:
Is this PR related with an open issue?
Related to Issue #218
Types of changes
Checklist:
Funny gif