Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing create and pay with ether #225

Merged
merged 3 commits into from
Feb 4, 2022
Merged

Fixing create and pay with ether #225

merged 3 commits into from
Feb 4, 2022

Conversation

mrsmkl
Copy link
Contributor

@mrsmkl mrsmkl commented Feb 3, 2022 •
edited

Description

Forgot to test this...

Is this PR related with an open issue?

Related to Issue #

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Follows the code style of this project.
  • Tests Cover Changes
  • Documentation

Funny gif

Put a link of a funny gif inside the parenthesis-->

@mrsmkl mrsmkl requested review from a team as code owners February 3, 2022 18:05
aaitor
aaitor approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@aaitor aaitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
I think we should bump to v1.3.5 here

@mrsmkl mrsmkl merged commit 323c931 into master Feb 4, 2022
@mrsmkl mrsmkl deleted the fix/create-and-pay-ether branch February 4, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaitor aaitor aaitor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mrsmkl @aaitor