Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support to Dutch Auctions #233

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Adding support to Dutch Auctions #233

merged 1 commit into from
Feb 10, 2022

Conversation

aaitor
Copy link
Member

@aaitor aaitor commented Feb 9, 2022

Description

It adds support for Dutch auctions (reverse to English Auctions)

Is this PR related with an open issue?

Related to Issue #232

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Follows the code style of this project.
  • Tests Cover Changes
  • Documentation

@aaitor aaitor requested review from a team as code owners February 9, 2022 17:18
@aaitor aaitor linked an issue Feb 9, 2022 that may be closed by this pull request
Implementation of Ducth Auction into contracts #232
Closed
mrsmkl
mrsmkl approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@mrsmkl mrsmkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@aaitor aaitor merged commit 0fa54aa into master Feb 10, 2022
@aaitor aaitor deleted the feature/dutch_auction branch February 10, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrsmkl mrsmkl mrsmkl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implementation of Ducth Auction into contracts
2 participants
@aaitor @mrsmkl