Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Transfer NFT Conditions documentation #292

Merged
merged 7 commits into from
May 18, 2022
Merged

Adding Transfer NFT Conditions documentation #292

merged 7 commits into from
May 18, 2022

Conversation

aaitor
Copy link
Member

@aaitor aaitor commented May 17, 2022 •
edited

Description

This PR:

  • Provides a new view in the transfer conditions to return the default NFT contract used in them. This facilitates backward compatibilities when the _contractAddress parameter is not given into the DDOs
  • Adds some missing documentation
  • Bumps to v2.0.0-rc1

Is this PR related with an open issue?

Related to Issue #

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Follows the code style of this project.
  • Tests Cover Changes
  • Documentation

Funny gif

Put a link of a funny gif inside the parenthesis-->

@aaitor aaitor marked this pull request as ready for review May 17, 2022 16:10
@aaitor aaitor requested review from a team as code owners May 17, 2022 16:10
@aaitor aaitor merged commit 37654b9 into develop May 18, 2022
@aaitor aaitor deleted the feature/missing_doc branch May 18, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@aaitor