Github Workflow refactor #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts. Deleted upload-artifacts workflow
…rtejoso/refactor-workflows
…rtejoso/refactor-workflows
…-io/contracts into jcortejoso/refactor-workflows
r-marques
reviewed
Jun 9, 2022
.github/workflows/release-github.yml
Outdated
Comment on lines
30
to
43
| - name: Compile and Lint | ||
| run: | | ||
| yarn lint | ||
| yarn clean | ||
| sh ./scripts/build.sh | ||
| yarn compile | ||
|
|
||
| - name: Run Unit Tests | ||
| run: | | ||
| yarn test:unit | ||
|
|
||
| - name: Run Integration Tests | ||
| run: | | ||
| yarn test:integration |
There was a problem hiding this comment.
does it make sense to lint and test before releasing? Typically you do a release on a green branch or you may want to do an rc release in a broken branch
There was a problem hiding this comment.
Happy to remove. I copied the building process to generate the artifacts, but I agree validating the release should not be needed as we should not release/merge when that is not green in any case.
r-marques
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
upload-artifacts.ymlworkflow (this atm must be executed locally by the contract deployer).Is this PR related with an open issue?
Related to Issue #
Types of changes
Checklist:
Funny gif