Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/dockerfile #314

Merged
merged 3 commits into from
May 26, 2022
Merged

Fix/dockerfile #314

merged 3 commits into from
May 26, 2022

Conversation

mrsmkl
Copy link
Contributor

@mrsmkl mrsmkl commented May 26, 2022

Description

Somehow the copying doesn't work anymore...

Is this PR related with an open issue?

Related to Issue #

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Follows the code style of this project.
  • Tests Cover Changes
  • Documentation

Funny gif

Put a link of a funny gif inside the parenthesis-->

@mrsmkl mrsmkl requested review from a team as code owners May 26, 2022 12:50
@mrsmkl mrsmkl changed the base branch from master to develop May 26, 2022 12:50
@mrsmkl
Copy link
Contributor Author

mrsmkl commented May 26, 2022

Probably good idea to test locally before merging...

@aaitor
Copy link
Member

aaitor commented May 26, 2022

testing locally with the latest commit looks the circuits folder is not there:

$ docker exec -it nevermined-keeper-node sh

/home/openethereum # ls /nevermined-contracts/
artifacts   artifacts2  circuits2
/home/openethereum # 

@mrsmkl
Copy link
Contributor Author

mrsmkl commented May 26, 2022

There shouldn't be artifacts2 anymore in the latest commit, can you retry? It's working here now...

@aaitor aaitor merged commit e0ac20e into develop May 26, 2022
@aaitor aaitor deleted the fix/dockerfile branch May 26, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants