Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provenance for conditions #326

Merged
merged 11 commits into from
Jun 23, 2022
Merged

Provenance for conditions #326

merged 11 commits into from
Jun 23, 2022

Conversation

mrsmkl
Copy link
Contributor

@mrsmkl mrsmkl commented Jun 15, 2022 •
edited

Description

Also added option for storing provenance record in "storage" optional, it will be in the events anyway...

Is this PR related with an open issue?

Related to Issue #325

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Follows the code style of this project.
  • Tests Cover Changes
  • Documentation

Funny gif

Put a link of a funny gif inside the parenthesis-->

@mrsmkl mrsmkl changed the base branch from master to develop June 15, 2022 13:11
@mrsmkl mrsmkl marked this pull request as ready for review June 15, 2022 14:03
@mrsmkl mrsmkl requested review from a team as code owners June 15, 2022 14:03
@mrsmkl mrsmkl requested a review from aaitor June 21, 2022 08:17
aaitor
aaitor approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@aaitor aaitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mrsmkl mrsmkl merged commit 8684f2c into develop Jun 23, 2022
@mrsmkl mrsmkl deleted the feat/more-provenance branch June 23, 2022 09:57
@aaitor aaitor linked an issue Jun 23, 2022 that may be closed by this pull request
Add fulfillment of conditions to Provenance #325
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaitor aaitor aaitor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add fulfillment of conditions to Provenance
3 participants
@mrsmkl @aaitor @jcortejoso